| Message ID | 50F2FF1B.3020708@mageia.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
Thomas Backlund skrev 13.1.2013 20:38: > patch both inline and attached as thunderbird tends to mess up ... > ----- > > if_bridge.h uses struct in6_addr ip6; but does not include the in6.h > header. > > Found by trying to build libvirt and connman against 3.8-rc3 headers. > Ok, ignore this patch, it's not the correct fix as it introduces redefinitions... Btw, the error that I hit that made me suggest this fix was libvirt config check bailing out: config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has incomplete type > Reported-by: Colin Guthrie <colin@mageia.org> > Reported-by: Christiaan Welvaart <cjw@daneel.dyndns.org> > Signed-off-by: Thomas Backlund <tmb@mageia.org> > > -- > > diff -Nurp linux-3.8-rc3/include/uapi/linux/if_bridge.h > linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h > --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 > 20:09:54.257271755 +0200 > +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 > 20:15:04.153676151 +0200 > @@ -14,6 +14,7 @@ > #define _UAPI_LINUX_IF_BRIDGE_H > > #include <linux/types.h> > +#include <linux/in6.h> > > #define SYSFS_BRIDGE_ATTR "bridge" > #define SYSFS_BRIDGE_FDB "brforward" > > > ----- > Thomas > -- Thomas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/13/2013 01:05 PM, Thomas Backlund wrote: > Thomas Backlund skrev 13.1.2013 20:38: >> patch both inline and attached as thunderbird tends to mess up ... > >> ----- >> >> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >> header. >> >> Found by trying to build libvirt and connman against 3.8-rc3 headers. >> > > Ok, > ignore this patch, it's not the correct fix as it introduces > redefinitions... > > Btw, the error that I hit that made me suggest this fix was libvirt > config check bailing out: > > config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has > incomplete type Hmm, just now noticing this thread, after independently hitting and and having to work around the same problem in libvirt: https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html https://bugzilla.redhat.com/show_bug.cgi?id=895141 >> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 >> 20:09:54.257271755 +0200 >> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 >> 20:15:04.153676151 +0200 >> @@ -14,6 +14,7 @@ >> #define _UAPI_LINUX_IF_BRIDGE_H >> >> #include <linux/types.h> >> +#include <linux/in6.h> >>
Eric Blake skrev 15.1.2013 01:57: > On 01/13/2013 01:05 PM, Thomas Backlund wrote: >> Thomas Backlund skrev 13.1.2013 20:38: >>> patch both inline and attached as thunderbird tends to mess up ... >> >>> ----- >>> >>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >>> header. >>> >>> Found by trying to build libvirt and connman against 3.8-rc3 headers. >>> >> >> Ok, >> ignore this patch, it's not the correct fix as it introduces >> redefinitions... >> >> Btw, the error that I hit that made me suggest this fix was libvirt >> config check bailing out: >> >> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has >> incomplete type > > Hmm, just now noticing this thread, after independently hitting and and > having to work around the same problem in libvirt: > https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html > https://bugzilla.redhat.com/show_bug.cgi?id=895141 Yep, and the commit breaking uapi headers is by using "struct in6_addr ip6" is: From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00:00:00 2001 From: Cong Wang <amwang@redhat.com> Date: Fri, 7 Dec 2012 00:04:48 +0000 Subject: [PATCH] bridge: export multicast database via netlink V5: fix two bugs pointed out by Thomas remove seq check for now, mark it as TODO V4: remove some useless #include some coding style fix V3: drop debugging printk's update selinux perm table as well V2: drop patch 1/2, export ifindex directly Redesign netlink attributes Improve netlink seq check Handle IPv6 addr as well This patch exports bridge multicast database via netlink message type RTM_GETMDB. Similar to fdb, but currently bridge-specific. We may need to support modify multicast database too (RTM_{ADD,DEL}MDB). (Thanks to Thomas for patient reviews) Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Stephen Hemminger <shemminger@vyatta.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Thomas Graf <tgraf@suug.ch> Cc: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Cong Wang <amwang@redhat.com> Acked-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> --- include/uapi/linux/if_bridge.h | 55 ++++++++++++++ include/uapi/linux/rtnetlink.h | 3 + net/bridge/Makefile | 2 +- net/bridge/br_mdb.c | 163 ++++++++++++++++++++++++++++++++++++++++ net/bridge/br_multicast.c | 1 + net/bridge/br_private.h | 1 + security/selinux/nlmsgtab.c | 1 + 7 files changed, 225 insertions(+), 1 deletions(-) create mode 100644 net/bridge/br_mdb.c -- Thomas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jan 14, 2013, at 5:57 PM, Eric Blake wrote: > On 01/13/2013 01:05 PM, Thomas Backlund wrote: >> Thomas Backlund skrev 13.1.2013 20:38: >>> patch both inline and attached as thunderbird tends to mess up ... >> >>> ----- >>> >>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >>> header. >>> >>> Found by trying to build libvirt and connman against 3.8-rc3 headers. >>> >> >> Ok, >> ignore this patch, it's not the correct fix as it introduces >> redefinitions... >> >> Btw, the error that I hit that made me suggest this fix was libvirt >> config check bailing out: >> >> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has >> incomplete type > > Hmm, just now noticing this thread, after independently hitting and and > having to work around the same problem in libvirt: > https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html > https://bugzilla.redhat.com/show_bug.cgi?id=895141 > >>> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 >>> 20:09:54.257271755 +0200 >>> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 >>> 20:15:04.153676151 +0200 >>> @@ -14,6 +14,7 @@ >>> #define _UAPI_LINUX_IF_BRIDGE_H >>> >>> #include <linux/types.h> >>> +#include <linux/in6.h> >>> Did this ever get resolved ? - k -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/13/2013 09:17 AM, Kumar Gala wrote: >>>> >>>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >>>> header. >>>> >>>> Found by trying to build libvirt and connman against 3.8-rc3 headers. >>>> >>> > Did this ever get resolved ? Libvirt has managed to work around the kernel issue in the meantime. But just today, I hit the same issue with the latest kernel-headers-3.8.2-206.fc18.x86_64 on Fedora 18 when backporting to an older libvirt branch that did not have the workaround. A kernel person would have to speak up for certain, but I think it is still a problem.
diff -Nurp linux-3.8-rc3/include/uapi/linux/if_bridge.h linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 20:09:54.257271755 +0200 +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 20:15:04.153676151 +0200 @@ -14,6 +14,7 @@ #define _UAPI_LINUX_IF_BRIDGE_H #include <linux/types.h> +#include <linux/in6.h> #define SYSFS_BRIDGE_ATTR "bridge" #define SYSFS_BRIDGE_FDB "brforward"