Patchwork [1/2] rpi-firmware: Fixup config.txt

login
register
mail settings
Submitter Maxime Hadjinlian
Date Jan. 13, 2013, 2:23 p.m.
Message ID <1358087034-2706-1-git-send-email-maxime.hadjinlian@gmail.com>
Download mbox | patch
Permalink /patch/211623/
State Accepted
Commit 3d2c99565856fa96320019dfb7b81fd18e66311f
Headers show

Comments

Maxime Hadjinlian - Jan. 13, 2013, 2:23 p.m.
The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
only a zImage kernel renamed.
Since Buildroot will build a zImage, the default config uses that should use it
instead of forcing the user to rename a file.

Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
there is no need to specify it on the cmdline.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/rpi-firmware/config.txt |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Maxime Hadjinlian - March 22, 2013, 12:05 p.m.
ping ?

On Sun, Jan 13, 2013 at 3:23 PM, Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote:
> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
> only a zImage kernel renamed.
> Since Buildroot will build a zImage, the default config uses that should use it
> instead of forcing the user to rename a file.
>
> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
> there is no need to specify it on the cmdline.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/rpi-firmware/config.txt |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
> index 2cabd68..a818762 100644
> --- a/package/rpi-firmware/config.txt
> +++ b/package/rpi-firmware/config.txt
> @@ -6,9 +6,10 @@
>
>  arm_freq=700
>  core_freq=250
> +kernel=zImage
>  disable_overscan=1
>  gpu_mem_256=100
>  gpu_mem_512=100
>  sdram_freq=400
>  over_voltage=0
> -cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
> +cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait"
> --
> 1.7.10.4
>
Alexey Brodkin - April 29, 2013, 8:31 a.m.
On 03/22/2013 04:05 PM, Maxime Hadjinlian wrote:
> ping ?

Seems like this patch has never been even reviewed since last January.
Even though it helps to use buildroot-built projects on RPi.

Is there a chance to get it reviewed/accepted?

Or is it supposed to be re-sent together with modifications in "[PATCH 
2/2] configs: add RaspberryPi defconfig"?

-Alexey

> On Sun, Jan 13, 2013 at 3:23 PM, Maxime Hadjinlian
> <maxime.hadjinlian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
>> only a zImage kernel renamed.
>> Since Buildroot will build a zImage, the default config uses that should use it
>> instead of forcing the user to rename a file.
>>
>> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
>> there is no need to specify it on the cmdline.
>>
>> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>   package/rpi-firmware/config.txt |    3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
>> index 2cabd68..a818762 100644
>> --- a/package/rpi-firmware/config.txt
>> +++ b/package/rpi-firmware/config.txt
>> @@ -6,9 +6,10 @@
>>
>>   arm_freq=700
>>   core_freq=250
>> +kernel=zImage
>>   disable_overscan=1
>>   gpu_mem_256=100
>>   gpu_mem_512=100
>>   sdram_freq=400
>>   over_voltage=0
>> -cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>> +cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait"
>> --
>> 1.7.10.4
>>
Arnout Vandecappelle - April 29, 2013, 8:23 p.m.
On 29/04/13 10:31, Alexey Brodkin wrote:
> Seems like this patch has never been even reviewed since last January.
> Even though it helps to use buildroot-built projects on RPi.
>
> Is there a chance to get it reviewed/accepted?
>
> Or is it supposed to be re-sent together with modifications in "[PATCH
> 2/2] configs: add RaspberryPi defconfig"?

  Hi Alexey,

  Feel free to test these patches and add your
Tested-by: ...
tag. Or to review them and add an Acked-by.

  Regards,
  Arnout
Thomas Petazzoni - April 29, 2013, 8:48 p.m.
Dear Maxime Hadjinlian,

On Sun, 13 Jan 2013 15:23:53 +0100, Maxime Hadjinlian wrote:
> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
> only a zImage kernel renamed.
> Since Buildroot will build a zImage, the default config uses that should use it
> instead of forcing the user to rename a file.
> 
> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
> there is no need to specify it on the cmdline.

I don't think this justification is correct. If ext4 is a module, then
rootfstype=ext4 doesn't make it work better. Specifying rootfstype=
tells the kernel what is the root filesystem, so that it doesn't have
to test the different available filesystem drivers.

I'm ok with the change, but I think the commit log is not correct.

Thanks,

Thomas
Maxime Hadjinlian - April 29, 2013, 10 p.m.
Hi all,

On Mon, Apr 29, 2013 at 10:48 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Maxime Hadjinlian,
>
> On Sun, 13 Jan 2013 15:23:53 +0100, Maxime Hadjinlian wrote:
>> The default name of the kernel binary for the RaspberryPi is kernel.img, it's a
>> only a zImage kernel renamed.
>> Since Buildroot will build a zImage, the default config uses that should use it
>> instead of forcing the user to rename a file.
>>
>> Also, remove the cmdline argument rootfstype, as ext4 is a builtin driver,
>> there is no need to specify it on the cmdline.
>
> I don't think this justification is correct. If ext4 is a module, then
> rootfstype=ext4 doesn't make it work better. Specifying rootfstype=
> tells the kernel what is the root filesystem, so that it doesn't have
> to test the different available filesystem drivers.
>
> I'm ok with the change, but I think the commit log is not correct.
>
You're right, the commit log is not accurate. I will rewrite it and
resend the patch.
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Patch

diff --git a/package/rpi-firmware/config.txt b/package/rpi-firmware/config.txt
index 2cabd68..a818762 100644
--- a/package/rpi-firmware/config.txt
+++ b/package/rpi-firmware/config.txt
@@ -6,9 +6,10 @@ 
 
 arm_freq=700
 core_freq=250
+kernel=zImage
 disable_overscan=1
 gpu_mem_256=100
 gpu_mem_512=100
 sdram_freq=400
 over_voltage=0
-cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
+cmdline="dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait"