Patchwork [U-Boot] mxs: Linux uses ttyAMA0 as DUART

login
register
mail settings
Submitter Marek Vasut
Date Jan. 11, 2013, 11:29 p.m.
Message ID <1357946982-10661-1-git-send-email-marex@denx.de>
Download mbox | patch
Permalink /patch/211452/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Marek Vasut - Jan. 11, 2013, 11:29 p.m.
Replace use of ttyAM0 with ttyAMA0 as default serial console.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
 include/configs/m28evk.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - Jan. 12, 2013, 1:24 p.m.
On Fri, Jan 11, 2013 at 9:29 PM, Marek Vasut <marex@denx.de> wrote:
> Replace use of ttyAM0 with ttyAMA0 as default serial console.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>

Please use the board name in the commit log.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Marek Vasut - Jan. 12, 2013, 4:14 p.m.
Dear Otavio Salvador,

> On Fri, Jan 11, 2013 at 9:29 PM, Marek Vasut <marex@denx.de> wrote:
> > Replace use of ttyAM0 with ttyAMA0 as default serial console.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Stefano Babic <sbabic@denx.de>
> 
> Please use the board name in the commit log.

I think mxs is enough.

Best regards,
Marek Vasut
Otavio Salvador - Jan. 12, 2013, 4:21 p.m.
On Sat, Jan 12, 2013 at 2:14 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Fri, Jan 11, 2013 at 9:29 PM, Marek Vasut <marex@denx.de> wrote:
>> > Replace use of ttyAM0 with ttyAMA0 as default serial console.
>> >
>> > Signed-off-by: Marek Vasut <marex@denx.de>
>> > Cc: Stefano Babic <sbabic@denx.de>
>>
>> Please use the board name in the commit log.
>
> I think mxs is enough.

I don't; you did not fix it for a SoC family neither it is a common
fix; You fixed it to m28evk only so it should be clear in the commit
log.


--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Stefano Babic - Jan. 21, 2013, 11:10 a.m.
On 12/01/2013 00:29, Marek Vasut wrote:
> Replace use of ttyAM0 with ttyAMA0 as default serial console.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 6887171..d34e970 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -274,7 +274,7 @@ 
 #define	CONFIG_SETUP_MEMORY_TAGS
 #define	CONFIG_BOOTDELAY	3
 #define	CONFIG_BOOTFILE		"uImage"
-#define	CONFIG_BOOTARGS		"console=ttyAM0,115200n8 "
+#define	CONFIG_BOOTARGS		"console=ttyAMA0,115200n8 "
 #define	CONFIG_BOOTCOMMAND	"run bootcmd_net"
 #define	CONFIG_LOADADDR		0x42000000
 #define	CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR