Patchwork [net-next] ipv4: fib: fix a comment.

login
register
mail settings
Submitter Rami Rosen
Date Jan. 11, 2013, 7:59 p.m.
Message ID <1357934360-17986-1-git-send-email-ramirose@gmail.com>
Download mbox | patch
Permalink /patch/211414/
State Accepted
Delegated to: David Miller
Headers show

Comments

Rami Rosen - Jan. 11, 2013, 7:59 p.m.
In fib_frontend.c, there is a confusing comment; NETLINK_CB(skb).portid does not 
refer to a pid of sending process, but rather to a netlink portid.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 net/ipv4/fib_frontend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Jan. 11, 2013, 11:59 p.m.
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 11 Jan 2013 21:59:20 +0200

> In fib_frontend.c, there is a confusing comment; NETLINK_CB(skb).portid does not 
> refer to a pid of sending process, but rather to a netlink portid.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 5cd75e2..99f00d3 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -974,7 +974,7 @@  static void nl_fib_input(struct sk_buff *skb)
 
 	nl_fib_lookup(frn, tb);
 
-	portid = NETLINK_CB(skb).portid;      /* pid of sending process */
+	portid = NETLINK_CB(skb).portid;      /* netlink portid */
 	NETLINK_CB(skb).portid = 0;        /* from kernel */
 	NETLINK_CB(skb).dst_group = 0;  /* unicast */
 	netlink_unicast(net->ipv4.fibnl, skb, portid, MSG_DONTWAIT);