Patchwork [1/2] target-arm: use type_register() instead of type_register_static()

login
register
mail settings
Submitter Peter Maydell
Date Jan. 11, 2013, 3:36 p.m.
Message ID <1357918615-24337-2-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/211368/
State New
Headers show

Comments

Peter Maydell - Jan. 11, 2013, 3:36 p.m.
From: Eduardo Habkost <ehabkost@redhat.com>

The type_register_static() interface is documented as:

  type_register_static:
  @info: The #TypeInfo of the new type.

  @info and all of the strings it points to should exist for the life
  time that the type is registered.

But cpu_register() uses a stack variable for the 'info' argument, so it
has to use type_register() instead of type_register_static().

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/cpu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/target-arm/cpu.c b/target-arm/cpu.c
index 17875ed..94536bb 100644
--- a/target-arm/cpu.c
+++ b/target-arm/cpu.c
@@ -778,7 +778,7 @@  static void cpu_register(const ARMCPUInfo *info)
         .class_size = sizeof(ARMCPUClass),
     };
 
-    type_register_static(&type_info);
+    type_register(&type_info);
 }
 
 static const TypeInfo arm_cpu_type_info = {