Patchwork [V2,2/2] oslib-win32: add lock for localtime_r()

login
register
mail settings
Submitter Wayne Xia
Date Jan. 11, 2013, 10:30 a.m.
Message ID <1357900227-5228-2-git-send-email-xiawenc@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/211293/
State New
Headers show

Comments

Wayne Xia - Jan. 11, 2013, 10:30 a.m.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

---
v2:
   better comments and removed the code change localtime() to localtime_r().
---
 oslib-win32.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Patch

diff --git a/oslib-win32.c b/oslib-win32.c
index 9a443da..aa1268c 100644
--- a/oslib-win32.c
+++ b/oslib-win32.c
@@ -90,15 +90,17 @@  struct tm *gmtime_r(const time_t *timep, struct tm *result)
     return p;
 }
 
-/* FIXME: add proper locking */
+/* FIXME: make it thread safe in MinGW, remove the lock in qemu. */
 struct tm *localtime_r(const time_t *timep, struct tm *result)
 {
+    g_static_mutex_lock(&time_lock);
     struct tm *p = localtime(timep);
     memset(result, 0, sizeof(*result));
     if (p) {
         *result = *p;
         p = result;
     }
+    g_static_mutex_unlock(&time_lock);
     return p;
 }