From patchwork Fri Jan 11 10:25:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 211291 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 995DF2C00BE for ; Fri, 11 Jan 2013 21:26:32 +1100 (EST) Received: from localhost ([::1]:38607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttboh-0000gT-GN for incoming@patchwork.ozlabs.org; Fri, 11 Jan 2013 05:26:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnW-0006va-Ey for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnT-0008GW-SF for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:14 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnT-00086h-Ki for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:11 -0500 Received: from blackfin.pond.sub.org (p5B32A660.dip.t-dialin.net [91.50.166.96]) by oxygen.pond.sub.org (Postfix) with ESMTPA id C22979FE6C; Fri, 11 Jan 2013 11:25:03 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 19B58200AD; Fri, 11 Jan 2013 11:25:03 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 11 Jan 2013 11:25:00 +0100 Message-Id: <1357899902-5316-5-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Michael Roth --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index d4fd628..5579185 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -45,6 +45,7 @@ static gboolean ga_channel_listen_accept(GIOChannel *channel, ret = ga_channel_client_add(c, client_fd); if (ret) { g_warning("error setting up connection"); + close(client_fd); goto out; } accepted = true;