From patchwork Fri Jan 11 10:25:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 211290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0164C2C00BE for ; Fri, 11 Jan 2013 21:26:15 +1100 (EST) Received: from localhost ([::1]:37096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtboP-0008Rj-Ql for incoming@patchwork.ozlabs.org; Fri, 11 Jan 2013 05:26:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnY-0006vn-TR for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtbnV-0008IR-5S for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:16 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:50758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtbnU-0008HR-V6 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:25:13 -0500 Received: from blackfin.pond.sub.org (p5B32A660.dip.t-dialin.net [91.50.166.96]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 8792C9FE7B; Fri, 11 Jan 2013 11:25:04 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 230EA200AE; Fri, 11 Jan 2013 11:25:03 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 11 Jan 2013 11:25:01 +0100 Message-Id: <1357899902-5316-6-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357899902-5316-1-git-send-email-armbru@redhat.com> References: <1357899902-5316-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Michael Roth --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 5579185..b530808 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -153,6 +153,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path, GAChannelMethod ret = ga_channel_client_add(c, fd); if (ret) { g_critical("error adding channel to main loop"); + close(fd); return false; } break;