Patchwork [1/6] qemu-ga: Document intentional fall through in channel_event_cb()

login
register
mail settings
Submitter Markus Armbruster
Date Jan. 11, 2013, 10:24 a.m.
Message ID <1357899902-5316-2-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/211289/
State New
Headers show

Comments

Markus Armbruster - Jan. 11, 2013, 10:24 a.m.
For clarity, and to hush up Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qga/main.c | 1 +
 1 file changed, 1 insertion(+)
Michael Roth - Jan. 11, 2013, 5:39 p.m.
On Fri, Jan 11, 2013 at 11:24:57AM +0100, Markus Armbruster wrote:
> For clarity, and to hush up Coverity.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qga/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qga/main.c b/qga/main.c
> index a9b968c..47a6bea 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -605,6 +605,7 @@ static gboolean channel_event_cb(GIOCondition condition, gpointer data)
>          if (!s->virtio) {
>              return false;
>          }
> +        /* fall through */
>      case G_IO_STATUS_AGAIN:
>          /* virtio causes us to spin here when no process is attached to
>           * host-side chardev. sleep a bit to mitigate this
> -- 
> 1.7.11.7
>

Patch

diff --git a/qga/main.c b/qga/main.c
index a9b968c..47a6bea 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -605,6 +605,7 @@  static gboolean channel_event_cb(GIOCondition condition, gpointer data)
         if (!s->virtio) {
             return false;
         }
+        /* fall through */
     case G_IO_STATUS_AGAIN:
         /* virtio causes us to spin here when no process is attached to
          * host-side chardev. sleep a bit to mitigate this