Patchwork [net] qlge: remove NETIF_F_TSO6 flag

login
register
mail settings
Submitter Amerigo Wang
Date Jan. 11, 2013, 8:52 a.m.
Message ID <1357894374-10767-1-git-send-email-amwang@redhat.com>
Download mbox | patch
Permalink /patch/211237/
State Accepted
Delegated to: David Miller
Headers show

Comments

Amerigo Wang - Jan. 11, 2013, 8:52 a.m.
It is werid that qlge driver supports NETIF_F_TSO6 but
not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1]
when VLAN device setups on a qlge interface.

I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM,
so we have to just remove the NETIF_F_TSO6 flag.

After this patch, the TCP/IPv6 traffic becomes normal again,
no kernel warnings any more.

NOTE: I only tested it on 2.6.32 kernel, even if the upstream
kernel could fix this automatically (it is hard to track NETIF*
flags), removing it is also safe.

1. https://bugzilla.redhat.com/show_bug.cgi?id=891839

Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: Ron Mercer <ron.mercer@qlogic.com>
Cc: linux-driver@qlogic.com
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>

---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jitendra Kalsaria - Jan. 11, 2013, 9:48 p.m.
>From: Cong Wang [mailto:amwang@redhat.com] 
>Sent: Friday, January 11, 2013 12:53 AM
>To: netdev
>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; David Miller; Cong Wang
>Subject: [PATCH net] qlge: remove NETIF_F_TSO6 flag
>
>It is werid that qlge driver supports NETIF_F_TSO6 but
>not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1]
>when VLAN device setups on a qlge interface.
>
>I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM,
>so we have to just remove the NETIF_F_TSO6 flag.
>
>After this patch, the TCP/IPv6 traffic becomes normal again,
>no kernel warnings any more.
>
>NOTE: I only tested it on 2.6.32 kernel, even if the upstream
>kernel could fix this automatically (it is hard to track NETIF*
>flags), removing it is also safe.
>
>1. https://bugzilla.redhat.com/show_bug.cgi?id=891839
>
>Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
>Cc: Ron Mercer <ron.mercer@qlogic.com>
>Cc: linux-driver@qlogic.com
>Cc: David S. Miller <davem@davemloft.net>
>Signed-off-by: Cong Wang <amwang@redhat.com>

Thanks!
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Jan. 11, 2013, 11:59 p.m.
From: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Date: Fri, 11 Jan 2013 21:48:52 +0000

> 
>>From: Cong Wang [mailto:amwang@redhat.com] 
>>Sent: Friday, January 11, 2013 12:53 AM
>>To: netdev
>>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; David Miller; Cong Wang
>>Subject: [PATCH net] qlge: remove NETIF_F_TSO6 flag
>>
>>It is werid that qlge driver supports NETIF_F_TSO6 but
>>not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1]
>>when VLAN device setups on a qlge interface.
>>
>>I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM,
>>so we have to just remove the NETIF_F_TSO6 flag.
>>
>>After this patch, the TCP/IPv6 traffic becomes normal again,
>>no kernel warnings any more.
>>
>>NOTE: I only tested it on 2.6.32 kernel, even if the upstream
>>kernel could fix this automatically (it is hard to track NETIF*
>>flags), removing it is also safe.
>>
>>1. https://bugzilla.redhat.com/show_bug.cgi?id=891839
>>
>>Cc: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
>>Cc: Ron Mercer <ron.mercer@qlogic.com>
>>Cc: linux-driver@qlogic.com
>>Cc: David S. Miller <davem@davemloft.net>
>>Signed-off-by: Cong Wang <amwang@redhat.com>
> 
> Thanks!
> Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index f80cd97..3e73742 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -4678,7 +4678,7 @@  static int qlge_probe(struct pci_dev *pdev,
 	qdev = netdev_priv(ndev);
 	SET_NETDEV_DEV(ndev, &pdev->dev);
 	ndev->hw_features = NETIF_F_SG | NETIF_F_IP_CSUM |
-		NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_TSO_ECN |
+		NETIF_F_TSO | NETIF_F_TSO_ECN |
 		NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;
 	ndev->features = ndev->hw_features |
 		NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;