Patchwork [U-Boot] mx6qsabreauto: enable USB host interface

login
register
mail settings
Submitter Dirk Behme
Date Jan. 11, 2013, 7:13 a.m.
Message ID <1357888407-14834-1-git-send-email-dirk.behme@de.bosch.com>
Download mbox | patch
Permalink /patch/211215/
State Changes Requested
Headers show

Comments

Dirk Behme - Jan. 11, 2013, 7:13 a.m.
From: Knut Wohlrab <knut.wohlrab@de.bosch.com>

The USB host interface is routed to plug USB1/J30 on the mother board.

Signed-off-by: Knut Wohlrab <knut.wohlrab@de.bosch.com>
---
 board/freescale/mx6qsabreauto/mx6qsabreauto.c |    7 +++++++
 include/configs/mx6qsabreauto.h               |   11 +++++++++++
 2 files changed, 18 insertions(+), 0 deletions(-)
Fabio Estevam - Jan. 11, 2013, 9:24 a.m.
On Fri, Jan 11, 2013 at 5:13 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> From: Knut Wohlrab <knut.wohlrab@de.bosch.com>
>
> The USB host interface is routed to plug USB1/J30 on the mother board.
>
> Signed-off-by: Knut Wohlrab <knut.wohlrab@de.bosch.com>

Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
Stefano Babic - Jan. 11, 2013, 9:30 a.m.
On 11/01/2013 08:13, Dirk Behme wrote:
> From: Knut Wohlrab <knut.wohlrab@de.bosch.com>
> 
> The USB host interface is routed to plug USB1/J30 on the mother board.
> 
> Signed-off-by: Knut Wohlrab <knut.wohlrab@de.bosch.com>
> ---

Hi Dirk,

>  board/freescale/mx6qsabreauto/mx6qsabreauto.c |    7 +++++++
>  include/configs/mx6qsabreauto.h               |   11 +++++++++++
>  2 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> index 9e3700e..696ddb4 100644
> --- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> +++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> @@ -101,6 +101,13 @@ static void setup_iomux_uart(void)
>  	imx_iomux_v3_setup_multiple_pads(uart4_pads, ARRAY_SIZE(uart4_pads));
>  }
>  
> +#ifdef CONFIG_USB_EHCI_MX6
> +int board_ehci_hcd_init(int port)
> +{
> +	return 0;
> +}
> +#endif

board_ehci_hcd_init is declared weak drivers/usb/host/ehci-mx6.c. You do
nothing in this function, why do you need ? You can completely drop it.

Best regards,
Stefano Babic

Patch

diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
index 9e3700e..696ddb4 100644
--- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
+++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
@@ -101,6 +101,13 @@  static void setup_iomux_uart(void)
 	imx_iomux_v3_setup_multiple_pads(uart4_pads, ARRAY_SIZE(uart4_pads));
 }
 
+#ifdef CONFIG_USB_EHCI_MX6
+int board_ehci_hcd_init(int port)
+{
+	return 0;
+}
+#endif
+
 #ifdef CONFIG_FSL_ESDHC
 struct fsl_esdhc_cfg usdhc_cfg[1] = {
 	{USDHC3_BASE_ADDR},
diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
index f1ff201..52d1a98 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -18,6 +18,17 @@ 
 #define CONFIG_MMCROOT			"/dev/mmcblk0p2"
 #define PHYS_SDRAM_SIZE		(2u * 1024 * 1024 * 1024)
 
+/* USB Configs */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_MX6
+#define CONFIG_USB_STORAGE
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_ASIX
+#define CONFIG_MXC_USB_PORT	1
+#define CONFIG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
+#define CONFIG_MXC_USB_FLAGS	0
+
 #include "mx6qsabre_common.h"
 
 #define CONFIG_SYS_FSL_USDHC_NUM	2