Patchwork [U-Boot,V2,1/2] EXYNOS5: Make all display related code dependent on CONFIG_LCD

login
register
mail settings
Submitter Ajay Kumar
Date Jan. 11, 2013, 7:06 a.m.
Message ID <1357887971-4464-1-git-send-email-ajaykumar.rs@samsung.com>
Download mbox | patch
Permalink /patch/211212/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Ajay Kumar - Jan. 11, 2013, 7:06 a.m.
u-boot compilation fails for smdk5250 when we deselect CONFIG_LCD
from the main config file.

Following error was observed:
drivers/video/libvideo.o: In function `exynos_lcd_init':
/home/ajay/u-boot-samsung/drivers/video/exynos_fb.c:68: undefined reference to `lcd_set_flush_dcache'

This is because exynos video drivers have dependency on CONFIG_LCD.

Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
---
Changes in V2:  Add compilation error message to commit log.

 board/samsung/smdk5250/smdk5250.c | 2 ++
 include/configs/exynos5250-dt.h   | 2 ++
 2 files changed, 4 insertions(+)
Minkyu Kang - Jan. 11, 2013, 8:20 a.m.
On 11/01/13 16:06, Ajay Kumar wrote:
> u-boot compilation fails for smdk5250 when we deselect CONFIG_LCD
> from the main config file.
> 
> Following error was observed:
> drivers/video/libvideo.o: In function `exynos_lcd_init':
> /home/ajay/u-boot-samsung/drivers/video/exynos_fb.c:68: undefined reference to `lcd_set_flush_dcache'
> 
> This is because exynos video drivers have dependency on CONFIG_LCD.
> 
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> Acked-by: Simon Glass <sjg@chromium.org>

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Patch

diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c
index 9c4bf9b..7a5f132 100644
--- a/board/samsung/smdk5250/smdk5250.c
+++ b/board/samsung/smdk5250/smdk5250.c
@@ -281,6 +281,7 @@  int board_early_init_f(void)
 }
 #endif
 
+#ifdef CONFIG_LCD
 void cfg_lcd_gpio(void)
 {
 	struct exynos5_gpio_part1 *gpio1 =
@@ -374,3 +375,4 @@  void init_panel_info(vidinfo_t *vid)
 
 	exynos_set_dp_platform_data(&dp_platform_data);
 }
+#endif
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 07bca1d..298bae9 100644
--- a/include/configs/exynos5250-dt.h
+++ b/include/configs/exynos5250-dt.h
@@ -299,10 +299,12 @@ 
 
 /* Display */
 #define CONFIG_LCD
+#ifdef CONFIG_LCD
 #define CONFIG_EXYNOS_FB
 #define CONFIG_EXYNOS_DP
 #define LCD_XRES			2560
 #define LCD_YRES			1600
 #define LCD_BPP			LCD_COLOR16
+#endif
 
 #endif	/* __CONFIG_H */