From patchwork Thu Jan 10 18:07:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 211109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 194CC2C0349 for ; Fri, 11 Jan 2013 05:07:18 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358446039; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=n4l23FU svvldKc0QMhdo3O63JJE=; b=qYjp0RJQP09W/RCDQxSyqqctFwFRC17FGXuLMlw In8sjEcoBPHMRZeekN5Qzf1no2GKOfB6vjbDzqqHsYajhs77EuyLOLq8OsEzaRHx GAAUHT+KvcKlPchejgvloCJ4LBvoPjPJlLjyYM6YBc+xPDVw398BKU8adqCrPFv2 U6C8= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=eRy2wdeL5JvNNeZ9f59B57GOpOb3lEBlLBqvEGjivqu/jkyT/STeDsuDKSsa6T X7pRmsTypJXgryaScTsYzez/oLH49J/SEPjg/9T7MMHZUkdkws1jIC2WjLDC4cU8 ADygL5aLPhz6pE2w5eOn2ZBvo8dlZpFhKbmMQFcC9iMBo=; Received: (qmail 19884 invoked by alias); 10 Jan 2013 18:07:07 -0000 Received: (qmail 19876 invoked by uid 22791); 10 Jan 2013 18:07:07 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jan 2013 18:07:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0AI722u004774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jan 2013 13:07:02 -0500 Received: from houston.quesejoda.com (vpn-53-229.rdu2.redhat.com [10.10.53.229]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0AI72n5013386; Thu, 10 Jan 2013 13:07:02 -0500 Message-ID: <50EF0345.5090003@redhat.com> Date: Thu, 10 Jan 2013 12:07:01 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches Subject: PR target/55565: update failing powerpc test Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org I have a long diatribe on the PR as to why the current generated code is correct, and more optimal than when the test used to "pass". Bottom line is that we now perform less branches and less loads/stores, at the expense of one register to register move. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55565 Jakub has been kind enough to provide an updated regex for the test. Tested on an x86-64 Linux cross to powerpc64-linux-gnu with: make check-gcc RUNTESTFLAGS=powerpc.exp=ppc-mov-1.c (by first removing the { target { powerpc*... } }). OK for trunk? commit 692859f796d90eebd97ad97ad872bbb7b7f49c12 Author: Aldy Hernandez Date: Thu Jan 10 11:58:37 2013 -0600 PR target/55565 * gcc.target/powerpc/ppc-mov-1.c: Update scan-assembler-not regex. diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-mov-1.c b/gcc/testsuite/gcc.target/powerpc/ppc-mov-1.c index 750cf85..d9439d9 100644 --- a/gcc/testsuite/gcc.target/powerpc/ppc-mov-1.c +++ b/gcc/testsuite/gcc.target/powerpc/ppc-mov-1.c @@ -1,7 +1,7 @@ /* { dg-do compile { target { powerpc*-*-* && lp64 } } } */ /* { dg-options "-O2" } */ -/* { dg-final { scan-assembler-not "fmr \[0-9\]+,\[0-9\]+" } } +/* { dg-final { scan-assembler-not "lfd \(\[0-9\]+\),\[^\n\r\]*\[\n\r\]+\[ \t]*fmr 1,\\1\[\n\r\]+\[ \t]*blr" } } */ /* Origin:Pete Steinmetz */