Patchwork [1/2] Fix phy_init for Marvell network eth driver

login
register
mail settings
Submitter Kosta Zertsekel
Date Jan. 10, 2013, noon
Message ID <1357819234-27752-2-git-send-email-konszert@marvell.com>
Download mbox | patch
Permalink /patch/210985/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Kosta Zertsekel - Jan. 10, 2013, noon
At least it fixes DNS323_REV_C1 board case (mach-orion5x/dsn323-setup.c file).

Change-Id: I37d64795f79c358f66a211a150cec2263e40e295
---
 drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sergei Shtylyov - Jan. 10, 2013, 1:22 p.m.
Hello.

On 10-01-2013 16:00, Kosta Zertsekel wrote:

> At least it fixes DNS323_REV_C1 board case (mach-orion5x/dsn323-setup.c file).

> Change-Id: I37d64795f79c358f66a211a150cec2263e40e295

    This line has no place in the upstream commit, please remove it. Also, the 
patch misses your signoff, so  couldn't be applied anyway. Same about the next 
patch.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 84c1326..7b8c1ac 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2789,7 +2789,7 @@  static void phy_init(struct mv643xx_eth_private *mp, int speed, int duplex)
 
 	phy_reset(mp);
 
-	phy_attach(mp->dev, dev_name(&phy->dev), 0, PHY_INTERFACE_MODE_GMII);
+	phy_attach(mp->dev, dev_name(&phy->dev), phy->dev_flags, PHY_INTERFACE_MODE_GMII);
 
 	if (speed == 0) {
 		phy->autoneg = AUTONEG_ENABLE;