Patchwork [v2,1/2] Adding yavta (Yet Another V4L2 Test Application) as a package

login
register
mail settings
Submitter kpa_info@yahoo.fr
Date Jan. 10, 2013, 10:58 a.m.
Message ID <1357815520-4461-1-git-send-email-kpa_info@yahoo.fr>
Download mbox | patch
Permalink /patch/210976/
State Superseded
Headers show

Comments

kpa_info@yahoo.fr - Jan. 10, 2013, 10:58 a.m.
From: Patrick Gerber <kpa_info@yahoo.fr>


Signed-off-by: Patrick Gerber <kpa_info@yahoo.fr>
---
 package/multimedia/Config.in       |    1 +
 package/multimedia/yavta/Config.in |    6 ++++++
 package/multimedia/yavta/yavta.mk  |   21 +++++++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/multimedia/yavta/Config.in
 create mode 100644 package/multimedia/yavta/yavta.mk
Thomas Petazzoni - Jan. 10, 2013, 11:16 a.m.
Dear kpa_info@yahoo.fr,

On Thu, 10 Jan 2013 11:58:39 +0100, kpa_info@yahoo.fr wrote:

> +config BR2_PACKAGE_YAVTA
> +	bool "yavta"
> +	help
> +	  Yet Another V4L2 Test Application
> +
> +     http://git.ideasonboard.org/yavta.git  

The indentation is wrong for the URL, and it confuses menuconfig, which
does not even start. Can you fix this indentation? I.e:

-     http://git.ideasonboard.org/media-ctl.git 
+         http://git.ideasonboard.org/media-ctl.git

Also, your URL line had trailing spaces.

Same problem on your media-ctl package.

Once this is fixed, for both packages:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks!

Thomas

Patch

diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
index 273d9bc..da558ca 100644
--- a/package/multimedia/Config.in
+++ b/package/multimedia/Config.in
@@ -24,4 +24,5 @@  source "package/multimedia/pulseaudio/Config.in"
 source "package/multimedia/tidsp-binaries/Config.in"
 source "package/multimedia/vorbis-tools/Config.in"
 source "package/multimedia/wavpack/Config.in"
+source "package/multimedia/yavta/Config.in"
 endmenu
diff --git a/package/multimedia/yavta/Config.in b/package/multimedia/yavta/Config.in
new file mode 100644
index 0000000..3cca5c1
--- /dev/null
+++ b/package/multimedia/yavta/Config.in
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_YAVTA
+	bool "yavta"
+	help
+	  Yet Another V4L2 Test Application
+
+     http://git.ideasonboard.org/yavta.git  
diff --git a/package/multimedia/yavta/yavta.mk b/package/multimedia/yavta/yavta.mk
new file mode 100644
index 0000000..1aa5574
--- /dev/null
+++ b/package/multimedia/yavta/yavta.mk
@@ -0,0 +1,20 @@ 
+#############################################################
+#
+# yavta
+#
+#############################################################
+
+YAVTA_VERSION = 82ff2efdb9787737b9f21b6f4759f077c827b238
+YAVTA_SITE = git://git.ideasonboard.org/yavta.git
+YAVTA_LICENSE = GPLv2
+YAVTA_LICENSE_FILES = COPYING.GPL
+
+define YAVTA_BUILD_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) 
+endef
+
+define YAVTA_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/yavta $(TARGET_DIR)/usr/bin/yavta
+endef
+
+$(eval $(generic-package))