Patchwork [1/1] infozip: new package

login
register
mail settings
Submitter Jan Pedersen
Date Jan. 10, 2013, 10:41 a.m.
Message ID <1357814466-3728-1-git-send-email-jp@jp-embedded.com>
Download mbox | patch
Permalink /patch/210973/
State Superseded
Headers show

Comments

Jan Pedersen - Jan. 10, 2013, 10:41 a.m.
This commit adds a package for infozip, compression and file
packaging/archive utility.

Signed-off-by: Jan Pedersen <jp@jp-embedded.com>
---
 package/Config.in          |    1 +
 package/infozip/Config.in  |   10 ++++++++++
 package/infozip/infozip.mk |   21 +++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/infozip/Config.in
 create mode 100644 package/infozip/infozip.mk
Thomas Petazzoni - Jan. 10, 2013, 11:15 a.m.
Dear Jan Pedersen,

On Thu, 10 Jan 2013 11:41:06 +0100, Jan Pedersen wrote:

> +INFOZIP_LICENSE_FILES = LICENCE

This is not correct, the file is called LICENSE.

You should run "make legal-info" when you create a new package, to
verify that the LICENSE_FILES field is correct.

> +define INFOZIP_BUILD_CMDS
> +	$(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
> +endef
> +
> +define INFOZIP_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
> +endef

Even though the package does not allow to override CFLAGS, I would
prefer if $(TARGET_CONFIGURE_OPTS) was used. It avoids for example the
mistake of forgetting the quotes around $(TARGET_CC). So, something
like:

define INFOZIP_BUILD_CMDS
	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile generic
endef

define INFOZIP_INSTALL_TARGET_CMDS
	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr
endef

Once this is fixed, you get my Acked-by and Tested-by, as I tested this
package.

Thanks!

Thomas

Patch

diff --git a/package/Config.in b/package/Config.in
index bd1db6b..1c2b228 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -14,6 +14,7 @@  endif
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
 source "package/xz/Config.in"
+source "package/infozip/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
diff --git a/package/infozip/Config.in b/package/infozip/Config.in
new file mode 100644
index 0000000..1a4b756
--- /dev/null
+++ b/package/infozip/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_INFOZIP
+	bool "infozip"
+	help
+	  Zip is a compression and file packaging/archive utility. 
+	  Although highly compatible both with PKWARE's PKZIP and 
+	  PKUNZIP utilities for MS-DOS and with Info-ZIP's own UnZip, 
+ 	  our primary objectives have been portability and other-than-MSDOS 
+	  functionality. 
+
+	  http://infozip.sourceforge.net/Zip.html
diff --git a/package/infozip/infozip.mk b/package/infozip/infozip.mk
new file mode 100644
index 0000000..ce6e88f
--- /dev/null
+++ b/package/infozip/infozip.mk
@@ -0,0 +1,21 @@ 
+#############################################################
+#
+# infozip
+#
+#############################################################
+INFOZIP_VERSION = 30
+INFOZIP_SOURCE = zip$(INFOZIP_VERSION).tgz
+INFOZIP_SITE = ftp://ftp.info-zip.org/pub/infozip/src
+INFOZIP_LICENSE = Info-ZIP
+INFOZIP_LICENSE_FILES = LICENCE
+
+define INFOZIP_BUILD_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile generic CC=$(TARGET_CC)
+endef
+
+define INFOZIP_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) -f unix/Makefile install prefix=$(TARGET_DIR)/usr CC=$(TARGET_CC)
+endef
+
+$(eval $(generic-package))
+