From patchwork Thu Jan 10 10:24:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kpa_info@yahoo.fr X-Patchwork-Id: 210972 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 329A72C032A for ; Thu, 10 Jan 2013 21:24:56 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 494E2A02B6; Thu, 10 Jan 2013 10:24:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0vPodjUGaaN4; Thu, 10 Jan 2013 10:24:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 47E98A02AE; Thu, 10 Jan 2013 10:24:51 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9C47D8F74B for ; Thu, 10 Jan 2013 10:24:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 446E48BA89 for ; Thu, 10 Jan 2013 10:24:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xCE0DvAxzIwG for ; Thu, 10 Jan 2013 10:24:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from nm24-vm6.bullet.mail.ird.yahoo.com (nm24-vm6.bullet.mail.ird.yahoo.com [212.82.109.197]) by whitealder.osuosl.org (Postfix) with ESMTPS id BAB278AFEB for ; Thu, 10 Jan 2013 10:24:43 +0000 (UTC) Received: from [77.238.189.52] by nm24.bullet.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:24:40 -0000 Received: from [217.146.188.162] by tm5.bullet.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:24:39 -0000 Received: from [127.0.0.1] by smtp130.mail.ird.yahoo.com with NNFMP; 10 Jan 2013 10:24:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.fr; s=s1024; t=1357813479; bh=cDIsOJYdI3vQsRAANE1Gt8ZBoS364DlXLrf+Eh8N+vs=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=vkDfHs5QdIgb/TeIJPWZzBCkNxBrAgU05isftNU//zPfsDY7n52Kie8d9Xus2d8pzmCEE1WXlcgOHyhpBT/0NyOCXizRnNM0jkAzr3tt4pgAO7FE34Szhbz/HlzDjkbYJ5lo7jRnLO0ACsh+MIvfX3k2RNl/SF4+WSO2Cb9q4cI= X-Yahoo-Newman-Id: 962349.91103.bm@smtp130.mail.ird.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: yvh0QtYVM1kNZ6AH6MpDEH2chO9_MRhvvFuWh3AoU7Dm1.M .RQAIV8xaiC7wzzn2LAT.sFTKskUXmjDAvzf6Pb.Ko05zYNv5qqBmLL4kDyp 3i2M8eu59DREQjSt2EmlJOBHdEJKZpX_qOuNfbFwIQzKRNCkrT.D25tDeC7f xWdY9OdMfFM_z46hhdRnJT7ue0onX3hVup3hmK9b1IvDTIIdFrpwiL4OZkd. X60bymIzoKeumjSCYX944yDy_E3avlM7DZX9psldNjlN60GjoyFgq4rHgMWm RrWnt1CY42ye_5LiAc8FDxAeNN9_56iPitOY31J4uaLckUbLmNW.nG_OdoM_ czdgyLlvxShKbjhaRVNoRuRL3KS3EOZumdh3iJ4jEh8CWH7s2nlyMYk9U7jI 5jKC0zLCQpohEhOo_5MD83x1PGffL4iUBfF4mWrbLFUxggx_Aoqv3VRlOXQ6 aLdjFdkRoh7qKHrCqrdw89mfWPyrzxlJrwKqVboNQnZ0VszNMXRN6pPi1faZ eaYDxKwSGCoDHBKjgfF3BDDPk9Qa0qRx.xChe6kccYSswtbGNhRr1NZDx6Cc KqN74y3j8ZsG73wGPaxFrOu82pDsYTSkC57Xy95Q- X-Yahoo-SMTP: gXxkLaeswBDA9gtBSIbQ8XWSflp0 Received: from [10.22.2.59] (kpa_info@46.140.83.238 with plain) by smtp130.mail.ird.yahoo.com with SMTP; 10 Jan 2013 02:24:39 -0800 PST Message-ID: <50EE96E1.70308@yahoo.fr> Date: Thu, 10 Jan 2013 11:24:33 +0100 From: Patrick User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Thomas Petazzoni References: <1357734594-8211-1-git-send-email-kpa_info@yahoo.fr> <1357734594-8211-2-git-send-email-kpa_info@yahoo.fr> <20130109170239.56a4e727@skate> In-Reply-To: <20130109170239.56a4e727@skate> Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH 2/2] Adding media-ctl as a package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On 01/09/2013 05:02 PM, Thomas Petazzoni wrote: > Dear kpa_info@yahoo.fr, > > On Wed, 9 Jan 2013 13:29:54 +0100, kpa_info@yahoo.fr wrote: >> +config BR2_PACKAGE_MEDIA_CTL >> + bool "media-ctl" >> + help >> + Media controller control application > > One empty newline + upstream URL of the project (even if it's just a > http link to the Git repository). And also the description seems a bit > short, since it does not only contains an application, but also a > library, no? > >> diff --git a/package/media-ctl/media-ctl.mk >> b/package/media-ctl/media-ctl.mk new file mode 100644 >> index 0000000..3c35278 >> --- /dev/null >> +++ b/package/media-ctl/media-ctl.mk >> @@ -0,0 +1,18 @@ >> +############################################################# >> +# >> +# media-ctl >> +# >> +############################################################# >> + >> +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7 >> +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git >> +MEDIA_CTL_INSTALL_STAGING = YES >> +MEDIA_CTL_LICENSE = GPLv2 > > The license is LGPLv2.1+. > >> +MEDIA_CTL_LICENSE_FILES = COPYING.LIB >> + >> +MEDIA_CTL_AUTORECONF = YES >> +MEDIA_CTL_AUTORECONF_OPT = --install > > Are you sure this AUTORECONF_OPT is needed? If so, then please add a > comment before this line that explains why. > >> +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include >> +MEDIA_CTL_DEPENDENCIES = host-pkgconf >> + >> +$(eval $(autotools-package)) > > Otherwise, looks good, thanks! > > Thomas > Dear Thomas, Please find below the new version of the patch according to your comments. Patrick From: Patrick Gerber Signed-off-by: Patrick Gerber --- package/Config.in | 1 + package/media-ctl/Config.in | 4 ++++ package/media-ctl/media-ctl.mk | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100644 package/media-ctl/Config.in create mode 100644 package/media-ctl/media-ctl.mk -- 1.7.9.5 diff --git a/package/Config.in b/package/Config.in index bd1db6b..2f3b601 100644 --- a/package/Config.in +++ b/package/Config.in @@ -245,6 +245,7 @@ source "package/lshw/Config.in" source "package/lsuio/Config.in" source "package/lvm2/Config.in" source "package/mdadm/Config.in" +source "package/media-ctl/Config.in" source "package/memtester/Config.in" source "package/minicom/Config.in" source "package/nanocom/Config.in" diff --git a/package/media-ctl/Config.in b/package/media-ctl/Config.in new file mode 100644 index 0000000..9fb888c --- /dev/null +++ b/package/media-ctl/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_MEDIA_CTL + bool "media-ctl" + help + Media controller control application + + http://git.ideasonboard.org/media-ctl.git diff --git a/package/media-ctl/media-ctl.mk b/package/media-ctl/media-ctl.mk new file mode 100644 index 0000000..3c35278 --- /dev/null +++ b/package/media-ctl/media-ctl.mk @@ -0,0 +1,17 @@ +############################################################# +# +# media-ctl +# +############################################################# + +MEDIA_CTL_VERSION = ac40b79f002a2315f909548614ccd2d408da25b7 +MEDIA_CTL_SITE = git://git.ideasonboard.org/media-ctl.git +MEDIA_CTL_INSTALL_STAGING = YES +MEDIA_CTL_LICENSE = LGPLv2.1+ +MEDIA_CTL_LICENSE_FILES = COPYING.LIB + +MEDIA_CTL_AUTORECONF = YES +MEDIA_CTL_CONF_OPT = --with-kernel-headers=$(STAGING_DIR)/usr/include +MEDIA_CTL_DEPENDENCIES = host-pkgconf + +$(eval $(autotools-package))