From patchwork Thu Jan 10 09:00:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Zhong X-Patchwork-Id: 210954 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 9ED262C0488 for ; Thu, 10 Jan 2013 20:01:01 +1100 (EST) Received: from e28smtp07.in.ibm.com (e28smtp07.in.ibm.com [122.248.162.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e28smtp07.in.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id BABF72C0216 for ; Thu, 10 Jan 2013 20:00:35 +1100 (EST) Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Jan 2013 14:29:07 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp07.in.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 10 Jan 2013 14:29:06 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id D1B681258051 for ; Thu, 10 Jan 2013 14:30:42 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0A90Q7u34406464 for ; Thu, 10 Jan 2013 14:30:26 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0A90QDt026160 for ; Thu, 10 Jan 2013 20:00:28 +1100 Received: from [9.123.247.96] ([9.123.247.96]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r0A90K5C025449 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Thu, 10 Jan 2013 20:00:21 +1100 Message-ID: <1357808418.10378.16.camel@ThinkPad-T5421.cn.ibm.com> Subject: [PATCH powerpc ] Avoid debug_smp_processor_id() check in arch_spin_unlock_wait() From: Li Zhong To: Benjamin Herrenschmidt Date: Thu, 10 Jan 2013 17:00:18 +0800 In-Reply-To: <1357797726.4838.89.camel@pasglop> References: <1353305799.3694.9.camel@ThinkPad-T5421.cn.ibm.com> <1357797726.4838.89.camel@pasglop> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13011008-8878-0000-0000-00000576D142 Cc: Paul Mackerras , "Paul E. McKenney" , PowerPC email list X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Use local_paca directly in arch_spin_unlock_wait(), as all processors have the same value for the field shared_proc, so we don't need care racy here. Reported-by: Paul E. McKenney Signed-off-by: Li Zhong --- arch/powerpc/lib/locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/lib/locks.c b/arch/powerpc/lib/locks.c index bb7cfec..850bea6 100644 --- a/arch/powerpc/lib/locks.c +++ b/arch/powerpc/lib/locks.c @@ -72,7 +72,7 @@ void arch_spin_unlock_wait(arch_spinlock_t *lock) { while (lock->slock) { HMT_low(); - if (SHARED_PROCESSOR) + if (local_paca->lppaca_ptr->shared_proc) __spin_yield(lock); } HMT_medium();