From patchwork Thu Jan 29 19:12:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 21089 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id C6BB9DE042 for ; Fri, 30 Jan 2009 07:35:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758825AbZA2Ufv (ORCPT ); Thu, 29 Jan 2009 15:35:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757984AbZA2Uft (ORCPT ); Thu, 29 Jan 2009 15:35:49 -0500 Received: from suva.vyatta.com ([76.74.103.44]:51502 "EHLO suva.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758455AbZA2Ufs (ORCPT ); Thu, 29 Jan 2009 15:35:48 -0500 Received: from suva.vyatta.com (suva [127.0.0.1]) by suva.vyatta.com (8.13.7/8.13.7) with ESMTP id n0TKXXwO012527; Thu, 29 Jan 2009 12:33:34 -0800 Received: (from shemminger@localhost) by suva.vyatta.com (8.13.7/8.13.7/Submit) id n0TKXX11012526; Thu, 29 Jan 2009 12:33:33 -0800 Message-Id: <20090129191520.012734381@vyatta.com> References: <20090129191239.483204605@vyatta.com> User-Agent: quilt/0.46-1 Date: Thu, 29 Jan 2009 11:12:40 -0800 From: Stephen Hemminger To: David Miller , Patrick McHardy Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: [PATCH 1/6] netfilter: change elements in x_tables Content-Disposition: inline; filename=x_tables.patch Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Change to proper type on private pointer rather than anonymous void. Keep active elements on same cache line. Signed-off-by: Stephen Hemminger --- include/linux/netfilter/x_tables.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/include/linux/netfilter/x_tables.h 2009-01-26 17:24:43.251543415 -0800 +++ b/include/linux/netfilter/x_tables.h 2009-01-26 17:29:12.510649107 -0800 @@ -349,9 +349,6 @@ struct xt_table { struct list_head list; - /* A unique name... */ - const char name[XT_TABLE_MAXNAMELEN]; - /* What hooks you will enter on */ unsigned int valid_hooks; @@ -359,13 +356,15 @@ struct xt_table rwlock_t lock; /* Man behind the curtain... */ - //struct ip6t_table_info *private; - void *private; + struct xt_table_info *private; /* Set this to THIS_MODULE if you are a module, otherwise NULL */ struct module *me; u_int8_t af; /* address/protocol family */ + + /* A unique name... */ + const char name[XT_TABLE_MAXNAMELEN]; }; #include