Patchwork toolchain/crosstool-ng: be more explicit in the config file help

login
register
mail settings
Submitter Yann E. MORIN
Date Jan. 9, 2013, 10:22 p.m.
Message ID <1357770170-30858-1-git-send-email-yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/210885/
State Superseded
Headers show

Comments

Yann E. MORIN - Jan. 9, 2013, 10:22 p.m.
Some users seem to interpret:
    make ctng-menuconfig

as being a value that can be fit for the ct-ng config file.

Clarify that it is a command to run, not a possible value.

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 toolchain/toolchain-crosstool-ng/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Thomas Petazzoni - Jan. 9, 2013, 10:39 p.m.
Dear Yann E. MORIN,

On Wed,  9 Jan 2013 23:22:50 +0100, Yann E. MORIN wrote:

>  	default "toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc"  if BR2_TOOLCHAIN_CTNG_glibc
>  	help
>  	  Enter here the crosstool-NG's .config file to use.

Enter here the path to the crosstool-NG .config file to use.

> -	  To fine-tune your toolchain, you can also call:
> +	  To fine-tune your toolchain, you may also run (from the
> +	  command line) this command:
>  	    make ctng-menuconfig
>  
>  	  If unsure, keep the default value.

I would insist a bit more here, something along the lines of:

 "Generally, the default crosstool-NG configuration files bundled with
 Buildroot work fine in most situations. Use 'make ctng-menuconfig'
 only for expert customization of your toolchain".

Thomas

Patch

diff --git a/toolchain/toolchain-crosstool-ng/Config.in b/toolchain/toolchain-crosstool-ng/Config.in
index d80f547..68061f0 100644
--- a/toolchain/toolchain-crosstool-ng/Config.in
+++ b/toolchain/toolchain-crosstool-ng/Config.in
@@ -44,7 +44,8 @@  config BR2_TOOLCHAIN_CTNG_CONFIG
 	default "toolchain/toolchain-crosstool-ng/crosstool-ng.config-glibc"  if BR2_TOOLCHAIN_CTNG_glibc
 	help
 	  Enter here the crosstool-NG's .config file to use.
-	  To fine-tune your toolchain, you can also call:
+	  To fine-tune your toolchain, you may also run (from the
+	  command line) this command:
 	    make ctng-menuconfig
 
 	  If unsure, keep the default value.