Patchwork [net-next] doc: Clarify behavior when sysctl tcp_ecn = 1

login
register
mail settings
Submitter Vijay Subramanian
Date Jan. 9, 2013, 10:21 p.m.
Message ID <1357770090-29253-1-git-send-email-subramanian.vijay@gmail.com>
Download mbox | patch
Permalink /patch/210884/
State Accepted
Delegated to: David Miller
Headers show

Comments

Vijay Subramanian - Jan. 9, 2013, 10:21 p.m.
Recent commit (commit 7e3a2dc52953 doc: make the description of how tcp_ecn
works more explicit and clear ) clarified the behavior of tcp_ecn sysctl
variable but description is inconsistent. When requested by incoming conections,
ECN is enabled with not just tcp_ecn = 2 but also with tcp_ecn = 1.

This patch makes it clear that with tcp_ecn = 1, ECN is enabled when requested
by incoming connections.

Also fix spelling of 'incoming'.

Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
---
 Documentation/networking/ip-sysctl.txt |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
David Miller - Jan. 10, 2013, 10:40 p.m.
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Wed,  9 Jan 2013 14:21:30 -0800

> Recent commit (commit 7e3a2dc52953 doc: make the description of how tcp_ecn
> works more explicit and clear ) clarified the behavior of tcp_ecn sysctl
> variable but description is inconsistent. When requested by incoming conections,
> ECN is enabled with not just tcp_ecn = 2 but also with tcp_ecn = 1.
> 
> This patch makes it clear that with tcp_ecn = 1, ECN is enabled when requested
> by incoming connections.
> 
> Also fix spelling of 'incoming'.
> 
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index dd52d51..51dcd52 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -214,8 +214,9 @@  tcp_ecn - INTEGER
 	congestion before having to drop packets.
 	Possible values are:
 		0 Disable ECN.  Neither initiate nor accept ECN.
-		1 Always request ECN on outgoing connection attempts.
-		2 Enable ECN when requested by incomming connections
+		1 Enable ECN when requested by incoming connections and
+		  also request ECN on outgoing connection attempts.
+		2 Enable ECN when requested by incoming connections
 		  but do not request ECN on outgoing connections.
 	Default: 2