[U-Boot] tegra30: cardhu: fix UART2 pinmux settings

Submitted by Allen Martin on Jan. 9, 2013, 6:14 p.m.

Details

Message ID 1357755262-9414-1-git-send-email-amartin@nvidia.com
State Superseded
Headers show

Commit Message

Allen Martin Jan. 9, 2013, 6:14 p.m.
Use UARTB instead of IRDA synonym for cardhu pinmux settings to match
tegra30 pinmux tables.

Signed-off-by: Allen Martin <amartin@nvidia.com>
---
 board/nvidia/cardhu/pinmux-config-cardhu.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Warren Jan. 9, 2013, 6:49 p.m.
On 01/09/2013 11:14 AM, Allen Martin wrote:
> Use UARTB instead of IRDA synonym for cardhu pinmux settings to match
> tegra30 pinmux tables.

This seems fine as far as it goes, but I'd suggest deleting the IRDA
value from the pinmux driver's enum too, so nobody can use it any more.
Allen Martin Jan. 9, 2013, 7 p.m.
On Wed, Jan 09, 2013 at 10:49:10AM -0800, Stephen Warren wrote:
> On 01/09/2013 11:14 AM, Allen Martin wrote:
> > Use UARTB instead of IRDA synonym for cardhu pinmux settings to match
> > tegra30 pinmux tables.
> 
> This seems fine as far as it goes, but I'd suggest deleting the IRDA
> value from the pinmux driver's enum too, so nobody can use it any more.

Good idea, will do.

-Allen

Patch hide | download patch | download mbox

diff --git a/board/nvidia/cardhu/pinmux-config-cardhu.h b/board/nvidia/cardhu/pinmux-config-cardhu.h
index 3162219..8428bba 100644
--- a/board/nvidia/cardhu/pinmux-config-cardhu.h
+++ b/board/nvidia/cardhu/pinmux-config-cardhu.h
@@ -176,8 +176,8 @@  static struct pingroup_config tegra3_pinmux_common[] = {
 	LV_PINMUX(VI_D7, SDMMC2, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
 	LV_PINMUX(VI_D10, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
 	LV_PINMUX(VI_MCLK, VI, UP, NORMAL, INPUT, DISABLE, DISABLE),
-	DEFAULT_PINMUX(UART2_RXD, IRDA, NORMAL, NORMAL, INPUT),
-	DEFAULT_PINMUX(UART2_TXD, IRDA, NORMAL, NORMAL, OUTPUT),
+	DEFAULT_PINMUX(UART2_RXD, UARTB, NORMAL, NORMAL, INPUT),
+	DEFAULT_PINMUX(UART2_TXD, UARTB, NORMAL, NORMAL, OUTPUT),
 	DEFAULT_PINMUX(UART2_RTS_N, UARTB, NORMAL, NORMAL, OUTPUT),
 	DEFAULT_PINMUX(UART2_CTS_N, UARTB, NORMAL, NORMAL, INPUT),
 	DEFAULT_PINMUX(UART3_TXD, UARTC, NORMAL, NORMAL, OUTPUT),