| Message ID | 470C14E4-2866-4C55-89A3-D6751E1587C4@ipflavors.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Romain KUNTZ wrote: > From e7ece201c35615c44a3cfdc10ee28ad5a5878f41 Mon Sep 17 00:00:00 2001 > From: Romain Kuntz <r.kuntz@ipflavors.com> > Date: Wed, 9 Jan 2013 15:02:26 +0100 > Subject: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route > > The tests on the flags in addrconf_get_prefix_route() does no make > much sense: the 'noflags' parameter contains the set of flags that > must not match with the route flags, so the test must be done > against 'noflags', and not against 'flags'. > > Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com> > --- > net/ipv6/addrconf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 408cac4a..29ba4ff 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -1877,7 +1877,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx, > continue; > if ((rt->rt6i_flags & flags) != flags) > continue; > - if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0)) > + if ((rt->rt6i_flags & noflags) != 0) > continue; > dst_hold(&rt->dst); > break; > Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Date: Thu, 10 Jan 2013 19:00:33 +0900 > Romain KUNTZ wrote: >> From e7ece201c35615c44a3cfdc10ee28ad5a5878f41 Mon Sep 17 00:00:00 2001 >> From: Romain Kuntz <r.kuntz@ipflavors.com> >> Date: Wed, 9 Jan 2013 15:02:26 +0100 >> Subject: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route >> >> The tests on the flags in addrconf_get_prefix_route() does no make >> much sense: the 'noflags' parameter contains the set of flags that >> must not match with the route flags, so the test must be done >> against 'noflags', and not against 'flags'. >> >> Signed-off-by: Romain Kuntz <r.kuntz@ipflavors.com> ... > Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 408cac4a..29ba4ff 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1877,7 +1877,7 @@ static struct rt6_info *addrconf_get_prefix_route(const struct in6_addr *pfx, continue; if ((rt->rt6i_flags & flags) != flags) continue; - if ((noflags != 0) && ((rt->rt6i_flags & flags) != 0)) + if ((rt->rt6i_flags & noflags) != 0) continue; dst_hold(&rt->dst); break;