From patchwork Wed Jan 9 12:35:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Henriques X-Patchwork-Id: 210710 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 946CA2C0172 for ; Wed, 9 Jan 2013 23:35:27 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TsusM-0004wY-05; Wed, 09 Jan 2013 12:35:22 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1TsusE-0004w0-Of for kernel-team@lists.ubuntu.com; Wed, 09 Jan 2013 12:35:14 +0000 Received: from bl20-120-205.dsl.telepac.pt ([2.81.120.205] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TsusE-0006Zt-Ij for kernel-team@lists.ubuntu.com; Wed, 09 Jan 2013 12:35:14 +0000 From: Luis Henriques To: kernel-team@lists.ubuntu.com Subject: [Oneiric CVE PATCH 1/1] tools: hv: Netlink source address validation allows DoS Date: Wed, 9 Jan 2013 12:35:12 +0000 Message-Id: <1357734912-18355-2-git-send-email-luis.henriques@canonical.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1357734912-18355-1-git-send-email-luis.henriques@canonical.com> References: <1357734912-18355-1-git-send-email-luis.henriques@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com From: Tomas Hozza CVE-2012-5532 BugLink: http://bugs.launchpad.net/bugs/1084777 The source code without this patch caused hypervkvpd to exit when it processed a spoofed Netlink packet which has been sent from an untrusted local user. Now Netlink messages with a non-zero nl_pid source address are ignored and a warning is printed into the syslog. Signed-off-by: Tomas Hozza Acked-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman (backported from commit 95a69adab9acfc3981c504737a2b6578e4d846ef) Signed-off-by: Luis Henriques Conflicts: tools/hv/hv_kvp_daemon.c --- drivers/staging/hv/tools/hv_kvp_daemon.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hv/tools/hv_kvp_daemon.c b/drivers/staging/hv/tools/hv_kvp_daemon.c index 1468a01..6399451 100644 --- a/drivers/staging/hv/tools/hv_kvp_daemon.c +++ b/drivers/staging/hv/tools/hv_kvp_daemon.c @@ -387,13 +387,19 @@ int main(void) len = recvfrom(fd, kvp_recv_buffer, sizeof(kvp_recv_buffer), 0, addr_p, &addr_l); - if (len < 0 || addr.nl_pid) { + if (len < 0) { syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s", addr.nl_pid, errno, strerror(errno)); close(fd); return -1; } + if (addr.nl_pid) { + syslog(LOG_WARNING, "Received packet from untrusted pid:%u", + addr.nl_pid); + continue; + } + incoming_msg = (struct nlmsghdr *)kvp_recv_buffer; incoming_cn_msg = (struct cn_msg *)NLMSG_DATA(incoming_msg);