From patchwork Wed Jan 9 11:56:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 210702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 418A82C0100 for ; Wed, 9 Jan 2013 22:56:48 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358337410; h=Comment: DomainKey-Signature:Received:Received:Received:Received:From:To: Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=+IJwHbTHAiNZalHwxi9TEvBQ/Gk=; b=UFSPBN6uG5asXUS Z0mj1iahhUmO4vy8NRK+yIPloWoA2laI2W2XEGsEYgdVUSQJbc2P2z0sbGf2MY+G zsck8a8RtFOdaBNsWRQcp5F31u99dVuqtNYJNYKZLBC1mfemj6cL2FVLsicEgIVV 1K5tw2sgPLfyAQVXN/lfWNLMSE8s= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:From:To:Cc:Subject:References:X-Yow:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=RJ8iIR1o73Mwj7oe6i2dge1s7ipU+8N1u1l/v/UfzLs1JaQ3K9V1TeUfUdkAhL ij5xwq3+LXgV9uGCn/AhbwoLcGFB0GpcLRbFF/eCpMy72M8ZN7u4YrxIiS4yPKbx PKskAHgJklhJgTvJhDKO9yQGWe6/ULJOddLDZYagh1Bsg=; Received: (qmail 14702 invoked by alias); 9 Jan 2013 11:56:39 -0000 Received: (qmail 14693 invoked by uid 22791); 9 Jan 2013 11:56:38 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jan 2013 11:56:34 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id F20E2A398E; Wed, 9 Jan 2013 12:56:32 +0100 (CET) From: Andreas Schwab To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Subject: Re: [PR54693] loss of debug info in jump threading and loop ivopts References: X-Yow: Well, O.K. I'll compromise with my principles because of EXISTENTIAL DESPAIR! Date: Wed, 09 Jan 2013 12:56:32 +0100 In-Reply-To: (Alexandre Oliva's message of "Fri, 26 Oct 2012 04:30:41 -0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Alexandre Oliva writes: > +int > +main () > +{ > + int i; > + char c; > + char arr[11]; > + > + for (i = 0; i < 10; i++) > + { > + c = 0x30 + i; > + foo (&arr[i], c); /* { dg-final { gdb-test 24 "i" "c - 48" } } */ > + } > + > + __builtin_printf ("arr = %s\n", arr); The string is not 0-terminated, which causes random characters to be output, and could even result in a spurious crash. Installed as obvious. Andreas. * gcc.dg/guality/pr54693.c: Null-terminate arr. diff --git a/gcc/testsuite/gcc.dg/guality/pr54693.c b/gcc/testsuite/gcc.dg/guality/pr54693.c index adc2dfd..b852c06 100644 --- a/gcc/testsuite/gcc.dg/guality/pr54693.c +++ b/gcc/testsuite/gcc.dg/guality/pr54693.c @@ -21,6 +21,7 @@ main () c = 0x30 + i; foo (&arr[i], c); /* { dg-final { gdb-test 22 "i" "c - 48" } } */ } + arr[10] = 0; __builtin_printf ("arr = %s\n", arr); return 0;