From patchwork Wed Jan 9 05:12:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wayne Xia X-Patchwork-Id: 210620 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 165D92C00D0 for ; Wed, 9 Jan 2013 16:16:17 +1100 (EST) Received: from localhost ([::1]:39831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tso1P-0001FM-4p for incoming@patchwork.ozlabs.org; Wed, 09 Jan 2013 00:16:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tso0G-0007Ti-E9 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 00:15:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tso0F-0008Vw-0R for qemu-devel@nongnu.org; Wed, 09 Jan 2013 00:15:04 -0500 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:49605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tso0E-0008R0-D2 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 00:15:02 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Jan 2013 10:43:33 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp06.in.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 9 Jan 2013 10:43:32 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id C9D29394004E for ; Wed, 9 Jan 2013 10:44:57 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r095EuNW48759004 for ; Wed, 9 Jan 2013 10:44:56 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r095Evl8021334 for ; Wed, 9 Jan 2013 16:14:57 +1100 Received: from RH63Wenchao ([9.77.181.189]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r095Ch6E014023; Wed, 9 Jan 2013 16:14:54 +1100 From: Wenchao Xia To: qemu-devel@nongnu.org Date: Wed, 9 Jan 2013 13:12:29 +0800 Message-Id: <1357708350-9917-11-git-send-email-xiawenc@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1357708350-9917-1-git-send-email-xiawenc@linux.vnet.ibm.com> X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13010905-9574-0000-0000-0000061993D6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 122.248.162.6 Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com, Wenchao Xia Subject: [Qemu-devel] [PATCH V2 10/11] hmp: retrieve info from qmp for snapshot info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org With this patch, hmp command info snapshot simply call a block layer funtion which will return a qmp object, and then translate it in monitor console. Now snapshot info retrieving code in qemu and qemu-tool are merged by calling same block layer function, and then they just translate the qmp to stdout or monitor. Note: This patch need previous hmp extention patch which enable info sub command take qdict * as paramter. v2: free SnapshotInfoList after usage. Signed-off-by: Wenchao Xia --- savevm.c | 84 +++++++++++++++++++++++++------------------------------------- 1 files changed, 34 insertions(+), 50 deletions(-) diff --git a/savevm.c b/savevm.c index 9af2605..cabdcb6 100644 --- a/savevm.c +++ b/savevm.c @@ -48,6 +48,7 @@ #include "qmp-commands.h" #include "trace.h" #include "qemu/bitops.h" +#include "hmp.h" #define SELF_ANNOUNCE_ROUNDS 5 @@ -2311,68 +2312,51 @@ void do_delvm(Monitor *mon, const QDict *qdict) } } -void do_info_snapshots(Monitor *mon, const QDict *qdict) +/* assume list is valid */ +static void monitor_dump_snapshotinfolist(Monitor *mon, SnapshotInfoList *list) { - BlockDriverState *bs, *bs1; - QEMUSnapshotInfo *sn_tab, *sn, s, *sn_info = &s; - int nb_sns, i, ret, available; - int total; - int *available_snapshots; + SnapshotInfoList *elem; char buf[256]; - bs = bdrv_snapshots(); - if (!bs) { - monitor_printf(mon, "No available block device supports snapshots\n"); - return; - } - - nb_sns = bdrv_snapshot_list(bs, &sn_tab); - if (nb_sns < 0) { - monitor_printf(mon, "bdrv_snapshot_list: error %d\n", nb_sns); - return; - } + monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), NULL)); - if (nb_sns == 0) { - monitor_printf(mon, "There is no snapshot available.\n"); - return; + for (elem = list; elem; elem = elem->next) { + QEMUSnapshotInfo sn = { + .vm_state_size = elem->value->vm_state_size, + .date_sec = elem->value->date_sec, + .date_nsec = elem->value->date_nsec, + .vm_clock_nsec = elem->value->vm_clock_sec * 1000000000ULL + + elem->value->vm_clock_nsec, + }; + pstrcpy(sn.id_str, sizeof(sn.id_str), elem->value->id); + pstrcpy(sn.name, sizeof(sn.name), elem->value->name); + monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), &sn)); } +} - available_snapshots = g_malloc0(sizeof(int) * nb_sns); - total = 0; - for (i = 0; i < nb_sns; i++) { - sn = &sn_tab[i]; - available = 1; - bs1 = NULL; - - while ((bs1 = bdrv_next(bs1))) { - if (bdrv_can_snapshot(bs1) && bs1 != bs) { - ret = bdrv_snapshot_find(bs1, sn_info, sn->id_str); - if (ret < 0) { - available = 0; - break; - } - } - } +static void do_info_snapshots_vm(Monitor *mon) +{ + Error *err = NULL; + SnapshotInfoList *list; - if (available) { - available_snapshots[total] = i; - total++; - } + list = qmp_query_snapshots(&err); + if (error_is_set(&err)) { + hmp_handle_error(mon, &err); + return; } - - if (total > 0) { - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), NULL)); - for (i = 0; i < total; i++) { - sn = &sn_tab[available_snapshots[i]]; - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), sn)); - } - } else { + if (list == NULL) { monitor_printf(mon, "There is no suitable snapshot available\n"); + return; } - g_free(sn_tab); - g_free(available_snapshots); + monitor_dump_snapshotinfolist(mon, list); + qapi_free_SnapshotInfoList(list); + return; +} +void do_info_snapshots(Monitor *mon, const QDict *qdict) +{ + do_info_snapshots_vm(mon); } void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev)