From patchwork Wed Jan 9 04:37:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hurugalawadi, Naveen" X-Patchwork-Id: 210612 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A6F6B2C00E7 for ; Wed, 9 Jan 2013 15:38:02 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358311083; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:From:To:CC:Subject:Date: Message-ID:References:In-Reply-To:Content-Type:MIME-Version: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=Yv0KBhw/tbuEcL6a2qxd sPKVD7M=; b=QzyFfWb9GFef+Zb2dq6D9OSR4xz2LcT2/C4Adwa42hbq8aA6PoOr 2Mhp4f/KB1p9ftoGkMMeQNb9o66Y/rnJ8YP3jL4tdWjBCZxwZWi1iAgi+3FkNQGH M4z5YVMFzcUkTNqtqvLVxfFwmn6aXDpa1dbxBvym7MGlmTUqp4oJqhE= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:X-Forefront-Antispam-Report:X-SpamScore:X-BigFish:Received:Received:Received:Received:From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:Content-Type:MIME-Version:X-OriginatorOrg:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=PkN0EvW5eOB3BoAw0qjY1ioOjQqIVRSnHNlnsJ3RkVKtEjH4dkEqw4m+WeEU4y C5vDWQsagEF9mp+rAK1W5UzWwXMskCSsG+mmAFvIvhZyxwzIHP4rvY8UqVAYnnV+ HQO7Bldhwliu48Ityiqsem1U0Mv2WQVk1PP9xHRgzgVpg=; Received: (qmail 14958 invoked by alias); 9 Jan 2013 04:37:18 -0000 Received: (qmail 14867 invoked by uid 22791); 9 Jan 2013 04:37:16 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from co1ehsobe005.messaging.microsoft.com (HELO co1outboundpool.messaging.microsoft.com) (216.32.180.188) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jan 2013 04:37:09 +0000 Received: from mail69-co1-R.bigfish.com (10.243.78.204) by CO1EHSOBE015.bigfish.com (10.243.66.78) with Microsoft SMTP Server id 14.1.225.23; Wed, 9 Jan 2013 04:37:07 +0000 Received: from mail69-co1 (localhost [127.0.0.1]) by mail69-co1-R.bigfish.com (Postfix) with ESMTP id 83311CC017B; Wed, 9 Jan 2013 04:37:07 +0000 (UTC) X-Forefront-Antispam-Report: CIP:157.56.236.133; KIP:(null); UIP:(null); IPV:NLI; H:BY2PRD0710HT001.namprd07.prod.outlook.com; RD:none; EFVD:NLI X-SpamScore: -3 X-BigFish: PS-3(zz936eIc85fh148cI4015Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzz8275bhz2dh2a8h668h839hd25hf0ah1288h12a5h12bdh137ah1441h1504h1537h153bh15d0h162dh1631h1758h34h1155h) Received: from mail69-co1 (localhost.localdomain [127.0.0.1]) by mail69-co1 (MessageSwitch) id 1357706224632331_26032; Wed, 9 Jan 2013 04:37:04 +0000 (UTC) Received: from CO1EHSMHS015.bigfish.com (unknown [10.243.78.211]) by mail69-co1.bigfish.com (Postfix) with ESMTP id 8E767C0054; Wed, 9 Jan 2013 04:37:04 +0000 (UTC) Received: from BY2PRD0710HT001.namprd07.prod.outlook.com (157.56.236.133) by CO1EHSMHS015.bigfish.com (10.243.66.25) with Microsoft SMTP Server (TLS) id 14.1.225.23; Wed, 9 Jan 2013 04:37:04 +0000 Received: from BY2PRD0710MB364.namprd07.prod.outlook.com ([169.254.3.163]) by BY2PRD0710HT001.namprd07.prod.outlook.com ([10.255.86.36]) with mapi id 14.16.0245.002; Wed, 9 Jan 2013 04:37:03 +0000 From: "Hurugalawadi, Naveen" To: Marcus Shawcroft CC: "gcc-patches@gcc.gnu.org" Subject: RE: [Patch, AARCH64] Define REVERSIBLE_CC_MODE Date: Wed, 9 Jan 2013 04:37:02 +0000 Message-ID: References: , In-Reply-To: MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Marcus, Thanks for reviewing the patch. >> Given the comment about SELECT_CC_MODE and the implementation of >> aarch64_select_cc_mode this definition of REVERSIBLE_CC_MODE looks >> broken to me. Please find attached the modified patch that does not allow floating point inequality comparisons in REVERSIBLE_CC_MODE. Please review the patch and let me know if its OK? Build and tested on aarch64-thunder-elf (using Cavium's internal simulator). No new regressions. Thanks, Naveen.H.S 2013-01-09 Naveen H.S * config/aarch64/aarch64.h (REVERSIBLE_CC_MODE): Define. --- gcc/config/aarch64/aarch64.h 2013-01-09 09:55:56.315992619 +0530 +++ gcc/config/aarch64/aarch64.h 2013-01-09 09:55:29.175991698 +0530 @@ -709,6 +709,14 @@ do { \ #define SELECT_CC_MODE(OP, X, Y) aarch64_select_cc_mode (OP, X, Y) +/* A C expression whose value is one if it is always safe to reverse a + comparison whose mode is MODE. If `SELECT_CC_MODE' can ever return + MODE for a floating-point inequality comparison, then + `REVERSIBLE_CC_MODE (MODE)' must be zero. + You need not define this macro if it would always returns zero or if the + floating-point format is anything other than `IEEE_FLOAT_FORMAT'. */ +#define REVERSIBLE_CC_MODE(MODE) ((MODE) != CCFPEmode) + #define REVERSE_CONDITION(CODE, MODE) \ (((MODE) == CCFPmode || (MODE) == CCFPEmode) \ ? reverse_condition_maybe_unordered (CODE) \