From patchwork Wed Jan 9 01:22:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 210586 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05F522C00AE for ; Wed, 9 Jan 2013 12:22:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755945Ab3AIBWy (ORCPT ); Tue, 8 Jan 2013 20:22:54 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:35587 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755860Ab3AIBWx (ORCPT ); Tue, 8 Jan 2013 20:22:53 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MGC00H763STJV80@mailout4.samsung.com> for linux-ide@vger.kernel.org; Wed, 09 Jan 2013 10:22:41 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 37.84.01231.166CCE05; Wed, 09 Jan 2013 10:22:41 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-2c-50ecc66172ad Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 17.84.01231.166CCE05; Wed, 09 Jan 2013 10:22:41 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MGC0042W3TTX360@mmp2.samsung.com> for linux-ide@vger.kernel.org; Wed, 09 Jan 2013 10:22:41 +0900 (KST) From: Jingoo Han To: 'Jeff Garzik' Cc: linux-ide@vger.kernel.org, 'Jingoo Han' Subject: [PATCH] ata: pata_samsung_cf: Use devm_clk_get() Date: Wed, 09 Jan 2013 10:22:41 +0900 Message-id: <002c01cdee07$d1ddacc0$75990640$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac3uB85lNf24vZn/Q7OT7O1RUS1nRg== Content-language: ko x-cr-hashedpuzzle: F9kB G4FO KNUV KalY K1Ro Lt3C OkYK Te0p XEgC cklZ cvnD dHSX dPPN jsts jxwY lRnQ; 3; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGoAZwBhAHIAegBpAGsAQABwAG8AYgBvAHgALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGkAZABlAEAAdgBnAGUAcgAuAGsAZQByAG4AZQBsAC4AbwByAGcA; Sosha1_v1; 7; {40136086-8FC7-4B89-BA10-7939210975E9}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Wed, 09 Jan 2013 01:22:35 GMT; WwBQAEEAVABDAEgAXQAgAGEAdABhADoAIABwAGEAdABhAF8AcwBhAG0AcwB1AG4AZwBfAGMAZgA6ACAAVQBzAGUAIABkAGUAdgBtAF8AYwBsAGsAXwBnAGUAdAAoACkA x-cr-puzzleid: {40136086-8FC7-4B89-BA10-7939210975E9} DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsVy+t8zY93EY28CDB63Wloc2/GIyYHR4/Mm uQDGKC6blNSczLLUIn27BK6MnoUn2QsOcVas2rWNrYHxJXsXIyeHhICJxOt1r5kgbDGJC/fW s3UxcnEICSxjlFiwZTZjFyMHWNGsH7oQ8emMEq1nOpggnBlMEt3zJ4F1swmoSXz5chhsqoiA qsTv/WsZQWxmAUeJN8s/M4PYwgKWEl0fVoHVsADVLJm5AyzOK2Ar0bagnx3CFpT4MfkeC0Sv lsT6nceZIGx5ic1r3jJDHKQu8eivLsQqPYldv59ArRKR2PfiHSPIbRICc1gkZj7fBvWlqcSv 469ZIfYKSHybfIgFYo6sxKYDzBD1i9glPjfOg4aEpMTBFTdYJjBKzEJy0iwkJ81CctIsJLsX MLKsYhRNLUguKE5KzzXUK07MLS7NS9dLzs/dxAiJLakdjCsbLA4xCnAwKvHwWs58EyDEmlhW XJl7iFGCg1lJhPeuN1CINyWxsiq1KD++qDQntfgQow/Q5ROZpUST84Fxn1cSb2hsbGJmYmpi bmlqbopDWEmcl/HUkwAhgfTEktTs1NSC1CKYcUwcnFINjB4JzK4/8kq/Vy0QnOWzlflkQPR3 vbcBW5adFoxxao/k0bOZcP1+nrjfj61rL6xN2K0w85/W5F9bPoR73yu+0uj3PEz90PlUv1RV rZjFvRGsVYbKO8Qi/SRnP9ha8yvmY4NFS+MWhU/Mivezm2t3HVH4UCSyYrPOxywvk0u8Rhuu z40sLxa+rcRSnJFoqMVcVJwIAN0pazDaAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jQd3EY28CDL7tN7U4tuMRkwOjx+dN cgGMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA U5UUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGT0LT7IXHOKsWLVrG1sD 40v2LkYODgkBE4lZP3S7GDmBTDGJC/fWs3UxcnEICUxnlGg908EE4cxgkuieP4kJpIpNQE3i y5fD7CC2iICqxO/9axlBbGYBR4k3yz8zg9jCApYSXR9WgdWwANUsmbkDLM4rYCvRtqCfHcIW lPgx+R4LRK+WxPqdx5kgbHmJzWveMkMcpy7x6K8uxCo9iV2/n0CtEpHY9+IdI8htEgJzWCRm Pt/GDvGBqcSv469ZJzAKzUKyYhaSFbOQrJiFZNYCRpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ +bmbGMGR+0xqB+PKBotDjAIcjEo8vJYz3wQIsSaWFVfmHmKU4GBWEuG96w0U4k1JrKxKLcqP LyrNSS0+xOgDDIGJzFKiyfnApJJXEm9obGJmZGlkZmFkYm6OQ1hJnJfx1JMAIYH0xJLU7NTU gtQimHFMHJxSDYznBcV311Us/dXkIvXGdKMn18+1Fx4fnDdXpoRD4XuzEJMk+6GM+3bPTl3r jrqqw1gwk38Bc8qNFdKmRr5eUQWGveuXbfzPzKOc//3ylo+PFStD4s/PLf3/XMhtS7r88Sgu hTccaq+thKM2bbJiMFo4IcBJtm/r6bVPN/M80Zjz52l01/Vp31iUWIozEg21mIuKEwHI7S3e CQMAAA== X-CFilter-Loop: Reflected Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org The devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_clk_get() for these functions. These make the code smaller and a bit simpler. Signed-off-by: Jingoo Han --- drivers/ata/pata_samsung_cf.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index 63ffb00..70b0e01 100644 --- a/drivers/ata/pata_samsung_cf.c +++ b/drivers/ata/pata_samsung_cf.c @@ -512,7 +512,7 @@ static int __init pata_s3c_probe(struct platform_device *pdev) return -ENOMEM; } - info->clk = clk_get(&pdev->dev, "cfcon"); + info->clk = devm_clk_get(&pdev->dev, "cfcon"); if (IS_ERR(info->clk)) { dev_err(dev, "failed to get access to cf controller clock\n"); ret = PTR_ERR(info->clk); @@ -589,7 +589,6 @@ static int __init pata_s3c_probe(struct platform_device *pdev) stop_clk: clk_disable(info->clk); - clk_put(info->clk); return ret; } @@ -601,7 +600,6 @@ static int __exit pata_s3c_remove(struct platform_device *pdev) ata_host_detach(host); clk_disable(info->clk); - clk_put(info->clk); return 0; }