From patchwork Tue Jan 8 22:59:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 210571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6B71C2C00B2 for ; Wed, 9 Jan 2013 10:44:22 +1100 (EST) Received: from localhost ([::1]:54339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsiF4-00081Y-9F for incoming@patchwork.ozlabs.org; Tue, 08 Jan 2013 18:05:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsiEI-0006Fe-Tf for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:05:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsiEH-0006ei-LF for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:05:10 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:40798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsiEH-0006e3-Hl for qemu-devel@nongnu.org; Tue, 08 Jan 2013 18:05:09 -0500 Received: by mail-ie0-f182.google.com with SMTP id s9so1277586iec.13 for ; Tue, 08 Jan 2013 15:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=H8XHZO7jSGgKYZbE4R53XK1iEzQeFqvveeFxbLJ6rcs=; b=RstrcIGPx6mW7cX1d5deQGsj1ONhT5qglp4zH1JOyaeeB9pU3RmRN2NBjD76+89zqB Fel0C9VxhJ+9KNvjNHiDCsA4Q0jfsjtWJUw0R06RyC1NQQ7iFQ8BwSkXeV+prf3NepCr h2vHF2PTv8yIsBtalRK9nxvmTjjlivuAktjj54N6XqG87aduxOe8u1RovdhjHou1mcMf lyvcpW+YlnI925H+opeH1kE6kkFdgBtKQAlfbk4KtN0ddn08RkEBRFlt8jJPP74yIQT9 BJ+qA6lDk0xMzzgcecSVT5kYx68W76VUn1JfqI1RHg48AgYwdQIyscWZP0q5+SJ+o0ih 4TTA== X-Received: by 10.50.220.202 with SMTP id py10mr10606248igc.109.1357686308952; Tue, 08 Jan 2013 15:05:08 -0800 (PST) Received: from localhost ([32.97.110.59]) by mx.google.com with ESMTPS id fa6sm778967igb.2.2013.01.08.15.05.07 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Jan 2013 15:05:08 -0800 (PST) From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2013 16:59:59 -0600 Message-Id: <1357686009-13139-3-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1357686009-13139-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1357686009-13139-1-git-send-email-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.223.182 Cc: aliguori@us.ibm.com, tomoki.sekiyama.qu@hitachi.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH 02/12] qemu-ga: qmp_guest_file_close(): fix fclose() error check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Luiz Capitulino fclose() returns EOF on error. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index bbef66d..ebb58be 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -170,7 +170,7 @@ void qmp_guest_file_close(int64_t handle, Error **err) } ret = fclose(gfh->fh); - if (ret == -1) { + if (ret == EOF) { error_set(err, QERR_QGA_COMMAND_FAILED, "fclose() failed"); return; }