| Submitter | Byungho An |
|---|---|
| Date | Jan. 8, 2013, 11:32 p.m. |
| Message ID | <000601cdedf8$5d39bdf0$17ad39d0$@samsung.com> |
| Download | mbox | patch |
| Permalink | /patch/210565/ |
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Byungho An <bh74.an@samsung.com> Date: Tue, 08 Jan 2013 15:32:02 -0800 > @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev, > > if (phy->autoneg) { > if (netif_running(netdev)) > + if((interface == PHY_INTERFACE_MODE_SGMII) || > + (interface == PHY_INTERFACE_MODE_TBI) || > + (interface == PHY_INTERFACE_MODE_RTBI)) > + priv->hw->mac->set_autoneg(priv->ioaddr); This is improperly indented and formatted, use this style: if (A || B || C) statement(); I can tell what you're trying to do, you are just trying to use TAB characters exclusivly to indent because you are lazy. But that's not the objective here. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 1372ce2..457c1a4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -335,6 +335,7 @@ stmmac_set_pauseparam(struct net_device *netdev, struct phy_device *phy = priv->phydev; int new_pause = FLOW_OFF; int ret = 0; + int interface = priv->plat->interface; spin_lock(&priv->lock); @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev, if (phy->autoneg) { if (netif_running(netdev)) + if((interface == PHY_INTERFACE_MODE_SGMII) || + (interface == PHY_INTERFACE_MODE_TBI) || + (interface == PHY_INTERFACE_MODE_RTBI)) + priv->hw->mac->set_autoneg(priv->ioaddr); ret = phy_start_aneg(phy); } else priv->hw->mac->flow_ctrl(priv->ioaddr, phy->duplex,
This patch adds gmac auto-negotiation setting for ethtool. If interface is SGMII, TBI or RTBI, gmac's auto-negotiation enable bit is need to set. Signed-off-by: Byungho An <bh74.an@samsung.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 5 +++++ 1 file changed, 5 insertions(+)