Patchwork linux: fix appended dtb handling of pre/postv3.8-rc1

login
register
mail settings
Submitter Sagaert Johan
Date Jan. 8, 2013, 10:21 p.m.
Message ID <10225438FF80469BB7C9CB5E373EC190@JohanW7>
Download mbox | patch
Permalink /patch/210552/
State Not Applicable
Headers show

Comments

Sagaert Johan - Jan. 8, 2013, 10:21 p.m.
Hi Arnout;

Just did a new build with this patch and it did'nt hang on the cat when the kernel was build.

Thanks.

Johan


-----Oorspronkelijk bericht-----
Van: buildroot-bounces@busybox.net [mailto:buildroot-bounces@busybox.net] Namens Arnout Vandecappelle (Essensium/Mind)
Verzonden: dinsdag 8 januari 2013 0:35
Aan: buildroot@busybox.net
Onderwerp: [Buildroot] [PATCH] linux: fix appended dtb handling of pre/postv3.8-rc1

From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>

Also fix duplication of 'define LINUX_APPEND_DTB' line, and refactor the common part out.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 linux/linux.mk |   28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

--
1.7.10.4

Patch

diff --git a/linux/linux.mk b/linux/linux.mk index 7ec9cd2..61d4267 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -201,24 +201,20 @@  endef
 endif
 endif
 
-ifeq ($(BR2_LINUX_KERNEL_APPENDED_UIMAGE),y)
-define LINUX_APPEND_DTB
-define LINUX_APPEND_DTB
-	# dtbs moved from arch/$ARCH/boot to arch/$ARCH/boot/dts since 3.8-rc1
-	cat $(wildcard $(addprefix $(KERNEL_ARCH_PATH)/boot/,\
-		$(KERNEL_DTS_NAME).dtb dts/$(KERNEL_DTS_NAME).dtb)) \
-		>> $(KERNEL_ARCH_PATH)/boot/zImage
-	# We need to generate the uImage here after that so that the uImage is
-	# generated with the right image size.
-	$(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) uImage
-endef
-else ifeq ($(BR2_LINUX_KERNEL_APPENDED_ZIMAGE),y)
+ifeq ($(BR2_LINUX_KERNEL_APPENDED_DTB),y)
+# dtbs moved from arch/$ARCH/boot to arch/$ARCH/boot/dts since 3.8-rc1
 define LINUX_APPEND_DTB
-	# dtbs moved from arch/$ARCH/boot to arch/$ARCH/boot/dts since 3.8-rc1
-	cat $(wildcard $(addprefix $(KERNEL_ARCH_PATH)/boot/,\
-		$(KERNEL_DTS_NAME).dtb dts/$(KERNEL_DTS_NAME).dtb)) \
-		>> $(KERNEL_ARCH_PATH)/boot/zImage
+	if [ -e $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb ]; then \
+		cat $(KERNEL_ARCH_PATH)/boot/$(KERNEL_DTS_NAME).dtb; \
+	else \
+		cat $(KERNEL_ARCH_PATH)/boot/dts/$(KERNEL_DTS_NAME).dtb; \
+	fi >> $(KERNEL_ARCH_PATH)/boot/zImage
 endef
+ifeq ($(BR2_LINUX_KERNEL_APPENDED_UIMAGE),y)
+# We need to generate the uImage here after that so that the uImage is 
+# generated with the right image size.
+LINUX_APPEND_DTB += $(sep)$(TARGET_MAKE_ENV) $(MAKE) 
+$(LINUX_MAKE_FLAGS) -C $(@D) uImage endif
 endif
 
 # Compilation. We make sure the kernel gets rebuilt when the