Patchwork [2/2] qemu-ga: add ga_open_logfile()

login
register
mail settings
Submitter Luiz Capitulino
Date Jan. 8, 2013, 9:26 p.m.
Message ID <1357680386-10904-3-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/210542/
State New
Headers show

Comments

Luiz Capitulino - Jan. 8, 2013, 9:26 p.m.
This function sets O_CLOEXEC on the log file fd so that it isn't
leaked to executed processes.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qga/main.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
Eric Blake - Jan. 8, 2013, 11:09 p.m.
On 01/08/2013 02:26 PM, Luiz Capitulino wrote:
> This function sets O_CLOEXEC on the log file fd so that it isn't
> leaked to executed processes.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qga/main.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Patch

diff --git a/qga/main.c b/qga/main.c
index e4245cc..15be74f 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -236,6 +236,19 @@  void ga_set_response_delimited(GAState *s)
     s->delimit_response = true;
 }
 
+static FILE *ga_open_logfile(const char *logfile)
+{
+    FILE *f;
+
+    f = fopen(logfile, "a");
+    if (!f) {
+        return NULL;
+    }
+
+    qemu_set_cloexec(fileno(f));
+    return f;
+}
+
 #ifndef _WIN32
 static bool ga_open_pidfile(const char *pidfile)
 {
@@ -377,7 +390,7 @@  void ga_unset_frozen(GAState *s)
      * in a frozen state at start up, do it now
      */
     if (s->deferred_options.log_filepath) {
-        s->log_file = fopen(s->deferred_options.log_filepath, "a");
+        s->log_file = ga_open_logfile(s->deferred_options.log_filepath);
         if (!s->log_file) {
             s->log_file = stderr;
         }
@@ -838,7 +851,7 @@  int main(int argc, char **argv)
             become_daemon(pid_filepath);
         }
         if (log_filepath) {
-            FILE *log_file = fopen(log_filepath, "a");
+            FILE *log_file = ga_open_logfile(log_filepath);
             if (!log_file) {
                 g_critical("unable to open specified log file: %s",
                            strerror(errno));