From patchwork Tue Jan 8 21:26:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/2] qemu-ga: ga_open_pidfile(): use qemu_open() Date: Tue, 08 Jan 2013 11:26:25 -0000 From: Luiz Capitulino X-Patchwork-Id: 210541 Message-Id: <1357680386-10904-2-git-send-email-lcapitulino@redhat.com> To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This ensures that O_CLOEXEC is passed to open(), this way the pid file fd is not leaked to executed processes. Signed-off-by: Luiz Capitulino Reviewed-by: Eric Blake --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index ba5fa1c..e4245cc 100644 --- a/qga/main.c +++ b/qga/main.c @@ -242,7 +242,7 @@ static bool ga_open_pidfile(const char *pidfile) int pidfd; char pidstr[32]; - pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); + pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) { g_critical("Cannot lock pid file, %s", strerror(errno)); if (pidfd != -1) {