Patchwork Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too

login
register
mail settings
Submitter Laszlo Ersek
Date Jan. 8, 2013, 6:52 p.m.
Message ID <1357671140-21713-1-git-send-email-lersek@redhat.com>
Download mbox | patch
Permalink /patch/210473/
State New
Headers show

Comments

Laszlo Ersek - Jan. 8, 2013, 6:52 p.m.
The WARNING message from commit f7e4dd6c made me notice.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Hajnoczi - Jan. 11, 2013, 8:48 a.m.
On Tue, Jan 08, 2013 at 07:52:20PM +0100, Laszlo Ersek wrote:
> The WARNING message from commit f7e4dd6c made me notice.
> 
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index a7ac04b..f6626b5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -280,6 +280,7 @@ bepo
>  ifdef INSTALL_BLOBS
>  BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
>  vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
> +acpi-dsdt.aml q35-acpi-dsdt.aml \
>  ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc \
>  pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom \
>  pxe-pcnet.rom pxe-rtl8139.rom pxe-virtio.rom \

I'm not familiar with the ACPI stuff and how we want to ship it.

Gerd or Anthony: Please review this patch.

Thanks,
Stefan
Gerd Hoffmann - Jan. 11, 2013, 8:54 a.m.
On 01/11/13 09:48, Stefan Hajnoczi wrote:
>> > +acpi-dsdt.aml q35-acpi-dsdt.aml \
> I'm not familiar with the ACPI stuff and how we want to ship it.
> 
> Gerd or Anthony: Please review this patch.

Patch is correct, just picked it up and stuffed into a q35 poll req.

cheers,
  Gerd

Patch

diff --git a/Makefile b/Makefile
index a7ac04b..f6626b5 100644
--- a/Makefile
+++ b/Makefile
@@ -280,6 +280,7 @@  bepo
 ifdef INSTALL_BLOBS
 BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
 vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
+acpi-dsdt.aml q35-acpi-dsdt.aml \
 ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc \
 pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom \
 pxe-pcnet.rom pxe-rtl8139.rom pxe-virtio.rom \