Patchwork wavpack: fix the iconv breakage ghost

login
register
mail settings
Submitter Gustavo Zacarias
Date Jan. 8, 2013, 6:04 p.m.
Message ID <1357668271-23025-1-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/210465/
State Accepted
Commit 3d5f83ffafb1ad3e9a9df975fb581931f2fa9606
Headers show

Comments

Gustavo Zacarias - Jan. 8, 2013, 6:04 p.m.
Fix missing comma in DEPENDENCIES, causing to pull in libiconv when it
wasn't necessary and causing other packages to go crazy on (e)glibc
toolchains which don't need it with libiconv being present. Fixes:
http://autobuild.buildroot.org/results/e0ce086a33a1db6fee77f43356e4e94ed6941f17

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/multimedia/wavpack/wavpack.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Korsgaard - Jan. 8, 2013, 11:36 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Fix missing comma in DEPENDENCIES, causing to pull in libiconv when it
 Gustavo> wasn't necessary and causing other packages to go crazy on (e)glibc
 Gustavo> toolchains which don't need it with libiconv being present. Fixes:
 Gustavo> http://autobuild.buildroot.org/results/e0ce086a33a1db6fee77f43356e4e94ed6941f17

Committed, thanks.

Patch

diff --git a/package/multimedia/wavpack/wavpack.mk b/package/multimedia/wavpack/wavpack.mk
index cd9b4f7..a7c703f 100644
--- a/package/multimedia/wavpack/wavpack.mk
+++ b/package/multimedia/wavpack/wavpack.mk
@@ -10,7 +10,7 @@  WAVPACK_SOURCE = wavpack-$(WAVPACK_VERSION).tar.bz2
 WAVPACK_INSTALL_STAGING = YES
 # configure not up to date
 WAVPACK_AUTORECONF = YES
-WAVPACK_DEPENDENCIES = $(if $(BR2_ENABLE_LOCALE),libiconv)
+WAVPACK_DEPENDENCIES = $(if $(BR2_ENABLE_LOCALE),,libiconv)
 WAVPACK_LICENSE = BSD-3c
 WAVPACK_LICENSE_FILES = license.txt