Patchwork [1/4] libnsdb: Fix string displayed for invalid security types

login
register
mail settings
Submitter Chuck Lever
Date Jan. 8, 2013, 5:30 p.m.
Message ID <20130108173026.65331.51229.stgit@seurat.1015granger.net>
Download mbox | patch
Permalink /patch/210458/
State Accepted
Headers show

Comments

Chuck Lever - Jan. 8, 2013, 5:30 p.m.
nsdb_display_fedfsconnectionsec() displays security types, not error
codes.

This has been incorrect since commit 0520ee72 "Initial commit", Tue
Mar 29 15:37:40 2011.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

 src/libnsdb/display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Chuck Lever - Jan. 8, 2013, 5:34 p.m.
On Jan 8, 2013, at 12:30 PM, Chuck Lever <chuck.lever@oracle.com> wrote:

> nsdb_display_fedfsconnectionsec() displays security types, not error
> codes.
> 
> This has been incorrect since commit 0520ee72 "Initial commit", Tue
> Mar 29 15:37:40 2011.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
> src/libnsdb/display.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/libnsdb/display.c b/src/libnsdb/display.c
> index d5e9763..eb15ed6 100644
> --- a/src/libnsdb/display.c
> +++ b/src/libnsdb/display.c
> @@ -48,7 +48,7 @@ nsdb_display_fedfsconnectionsec(const FedFsConnectionSec sectype)
> 	default:
> 		break;
> 	}
> -	return "an unrecognized error code";
> +	return "unrecognized security type";
> }
> 
> /**

Sorry, Gmail's SMTP service hung up on me while sending this week's series.  Patch 1/4 in this thread is the same as 10/13, 2/4 in this thread is what would have been 11/13, and so on.

Patch

diff --git a/src/libnsdb/display.c b/src/libnsdb/display.c
index d5e9763..eb15ed6 100644
--- a/src/libnsdb/display.c
+++ b/src/libnsdb/display.c
@@ -48,7 +48,7 @@  nsdb_display_fedfsconnectionsec(const FedFsConnectionSec sectype)
 	default:
 		break;
 	}
-	return "an unrecognized error code";
+	return "unrecognized security type";
 }
 
 /**