From patchwork Mon Jan 7 20:38:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nickolai Zeldovich X-Patchwork-Id: 210224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 734CB2C0094 for ; Tue, 8 Jan 2013 07:39:21 +1100 (EST) Received: from localhost ([::1]:41914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJTb-00020s-KC for incoming@patchwork.ozlabs.org; Mon, 07 Jan 2013 15:39:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJTR-00020V-Ex for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJTK-0005aL-HC for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:09 -0500 Received: from amsterdam.lcs.mit.edu ([18.26.4.9]:48411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJTK-0005Ye-C3 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 15:39:02 -0500 Received: (from root@localhost) by amsterdam.lcs.mit.edu (8.14.4/8.13.8) id r07Kcjsv054364; Mon, 7 Jan 2013 15:38:45 -0500 (EST) (envelope-from nickolai@amsterdam.lcs.mit.edu) Received: from ben.csail.mit.edu (ben.csail.mit.edu [18.26.4.122]) (TLSv1/SSLv3 DHE-RSA-AES128-SHA 128/128) by amsterdam.lcs.mit.edu with SMTP; Mon, 07 Jan 2013 15:38:45 -0500 (EST) (envelope-from nickolai@pdos.csail.mit.edu) Received: from nickolai by ben.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1TsJT3-000AVi-3W; Mon, 07 Jan 2013 15:38:45 -0500 From: Nickolai Zeldovich To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2013 15:38:39 -0500 Message-Id: <1357591119-40326-1-git-send-email-nickolai@csail.mit.edu> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-Received-From: 18.26.4.9 Cc: Nickolai Zeldovich Subject: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org memcpy() for overlapping regions is undefined behavior; use memmove() instead in readline_hist_add(). Signed-off-by: Nickolai Zeldovich Reviewed-by: Richard Henderson --- readline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index 5fc9643..aeccc7b 100644 --- a/readline.c +++ b/readline.c @@ -248,8 +248,8 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) if (idx == READLINE_MAX_CMDS) { /* Need to get one free slot */ free(rs->history[0]); - memcpy(rs->history, &rs->history[1], - (READLINE_MAX_CMDS - 1) * sizeof(char *)); + memmove(rs->history, &rs->history[1], + (READLINE_MAX_CMDS - 1) * sizeof(char *)); rs->history[READLINE_MAX_CMDS - 1] = NULL; idx = READLINE_MAX_CMDS - 1; }