Patchwork [mips] Change -mad to -mmad to match documentation

login
register
mail settings
Submitter Steve Ellcey
Date Jan. 7, 2013, 7:27 p.m.
Message ID <786b4481-9093-40bc-ae04-d3501a4a05ef@EXCHHUB01.MIPS.com>
Download mbox | patch
Permalink /patch/210062/
State New
Headers show

Comments

Steve Ellcey - Jan. 7, 2013, 7:27 p.m.
The MIPS documentation describes a -mmad (-mno-mad) flag, but it is incorrectly
implemented as -mad (-mno-ad) instead.  This patch changes the implementation
to match the documentation.  This means that users who are currently using the
-mad or -mno-ad flags would have to change.  If we want we could leave -mad and
-mno-ad as aliases for -mmad and -mno-ad but I don't think that is necessary.

If someone does think we should do allow -mad, please let me know.

OK to checkin?

Steve Ellcey
sellcey@mips.com


2013-01-07  Steve Ellcey  <sellcey@mips.com>

	PR target/42661
	* config/mips/mips.opt: Change mad to mmad to match documentation.
Richard Sandiford - Jan. 7, 2013, 8:33 p.m.
"Steve Ellcey " <sellcey@mips.com> writes:
> The MIPS documentation describes a -mmad (-mno-mad) flag, but it is incorrectly
> implemented as -mad (-mno-ad) instead.  This patch changes the implementation
> to match the documentation.  This means that users who are currently using the
> -mad or -mno-ad flags would have to change.  If we want we could leave -mad and
> -mno-ad as aliases for -mmad and -mno-ad but I don't think that is necessary.
>
> If someone does think we should do allow -mad, please let me know.
>
> OK to checkin?

OK, thanks.  Looks like I introduced this in the TARGET_OPTINS ->
.opt-file conversion.

Richard

Patch

diff --git a/gcc/config/mips/mips.opt b/gcc/config/mips/mips.opt
index dec028d..201d46f 100644
--- a/gcc/config/mips/mips.opt
+++ b/gcc/config/mips/mips.opt
@@ -55,7 +55,7 @@  mabicalls
 Target Report Mask(ABICALLS)
 Generate code that can be used in SVR4-style dynamic objects
 
-mad
+mmad
 Target Report Var(TARGET_MAD)
 Use PMC-style 'mad' instructions