From patchwork Mon Jan 7 15:38:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 209996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C376A2C009F for ; Tue, 8 Jan 2013 03:49:31 +1100 (EST) Received: from localhost ([::1]:53495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsEoO-00068t-Vy for incoming@patchwork.ozlabs.org; Mon, 07 Jan 2013 10:40:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsEnI-0004mP-5l for qemu-devel@nongnu.org; Mon, 07 Jan 2013 10:39:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsEnE-00078Y-71 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 10:39:19 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39898 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsEnD-00078K-Tv; Mon, 07 Jan 2013 10:39:16 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 62163A51C9; Mon, 7 Jan 2013 16:39:15 +0100 (CET) From: Alexander Graf To: qemu-devel@nongnu.org Date: Mon, 7 Jan 2013 16:38:45 +0100 Message-Id: <1357573140-8877-17-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1357573140-8877-1-git-send-email-agraf@suse.de> References: <1357573140-8877-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: Blue Swirl , Scott Wood , qemu-ppc@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PATCH 16/31] openpic: make ctpr signed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Scott Wood Other priorities are signed, so avoid comparisons between signed and unsigned. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- hw/openpic.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index fe6cf67..824b8fd 100644 --- a/hw/openpic.c +++ b/hw/openpic.c @@ -215,7 +215,7 @@ typedef struct IRQSource { #define IDR_CI 0x40000000 /* critical interrupt */ typedef struct IRQDest { - uint32_t ctpr; /* CPU current task priority */ + int32_t ctpr; /* CPU current task priority */ IRQQueue raised; IRQQueue servicing; qemu_irq *irqs; @@ -1150,7 +1150,7 @@ static void openpic_save(QEMUFile* f, void *opaque) qemu_put_be32s(f, &opp->nb_cpus); for (i = 0; i < opp->nb_cpus; i++) { - qemu_put_be32s(f, &opp->dst[i].ctpr); + qemu_put_sbe32s(f, &opp->dst[i].ctpr); openpic_save_IRQ_queue(f, &opp->dst[i].raised); openpic_save_IRQ_queue(f, &opp->dst[i].servicing); } @@ -1197,7 +1197,7 @@ static int openpic_load(QEMUFile* f, void *opaque, int version_id) qemu_get_be32s(f, &opp->nb_cpus); for (i = 0; i < opp->nb_cpus; i++) { - qemu_get_be32s(f, &opp->dst[i].ctpr); + qemu_get_sbe32s(f, &opp->dst[i].ctpr); openpic_load_IRQ_queue(f, &opp->dst[i].raised); openpic_load_IRQ_queue(f, &opp->dst[i].servicing); }