Patchwork [doc,avr] ad PR54461: Document --with-avrlibc

login
register
mail settings
Submitter Georg-Johann Lay
Date Jan. 7, 2013, 3:01 p.m.
Message ID <50EAE357.8000504@gjlay.de>
Download mbox | patch
Permalink /patch/209945/
State New
Headers show

Comments

Georg-Johann Lay - Jan. 7, 2013, 3:01 p.m.
This addendum adds --with-avrlibc to the (web) documentation.

It inserts the explanation after --with-newlib which seems to be a reasonable
place.

Ok to apply?

Johann


	PR target/PR54461
	* doc/install.texi (Cross-Compiler-Specific Options): Document
	--with-avrlibc.
Weddington, Eric - Jan. 7, 2013, 3:21 p.m.
> -----Original Message-----

> From: Georg-Johann Lay 

> Sent: Monday, January 07, 2013 8:02 AM

> To: gcc-patches@gcc.gnu.org

> Cc: Denis Chertykov; Weddington, Eric; Gerald Pfeifer

> Subject: [patch,doc,avr] ad PR54461: Document --with-avrlibc

> 

> This addendum adds --with-avrlibc to the (web) documentation.

> 

> It inserts the explanation after --with-newlib which seems to be a

> reasonable

> place.

> 

> Ok to apply?

>


Change:

+This option is only supported for the AVR target and only for
+non-RTEMS configurations.  The options is supported since version

To:

+This option is only supported for the AVR target and only for
+non-RTEMS configurations, which currently use newlib.  The option is supported since version

Note misspelling of "option" on second line. (You have the plural form when it should be singular.

Because avr-libc is used more frequently than newlib, and especially since it is default (for a version and above), what about placing this option text *before* --with-newlib in the manual?

Eric
Georg-Johann Lay - Jan. 7, 2013, 3:28 p.m.
Weddington, Eric wrote:
> 
> Georg-Johann Lay Sent
>> Document --with-avrlibc
>> 
>> This addendum adds --with-avrlibc to the (web) documentation.
>> 
>> It inserts the explanation after --with-newlib which seems to be a 
>> reasonable place.
>> 
>> Ok to apply?
>> 
> 
> Change:
> 
> +This option is only supported for the AVR target and only for +non-RTEMS
> configurations.  The options is supported since version
> 
> To:
> 
> +This option is only supported for the AVR target and only for +non-RTEMS
> configurations, which currently use newlib.  The option is supported since
> version
> 
> Note misspelling of "option" on second line. (You have the plural form when
> it should be singular.

Thanks.

> Because avr-libc is used more frequently than newlib, and especially since
> it is default (for a version and above), what about placing this option text
> *before* --with-newlib in the manual?

I put it after newlib because I think newlib is far more common (to the general
reader of the GCC install docs).

Johann
Weddington, Eric - Jan. 7, 2013, 3:35 p.m.
> -----Original Message-----

> From: Georg-Johann Lay 

> Sent: Monday, January 07, 2013 8:28 AM

> To: Weddington, Eric

> Cc: gcc-patches@gcc.gnu.org; Denis Chertykov; Gerald Pfeifer

> Subject: Re: [patch,doc,avr] ad PR54461: Document --with-avrlibc

> 

> > +This option is only supported for the AVR target and only for +non-

> RTEMS

> > configurations, which currently use newlib.  The option is supported

> since

> > version


I forgot to mention that it looks like there might be some work to get avr rtems target working with avr-libc. But that is unknown timing at this point.

Ok to commit with the changes you made.

Thanks!
Eric
Georg-Johann Lay - Jan. 7, 2013, 4:17 p.m.
Weddington, Eric wrote:
> Georg-Johann Lay Sent
>> Document --with-avrlibc
>> 
>>> This option is only supported for the AVR target and only for non-RTEMS
>>> configurations, which currently use newlib.  The option is supported
>>> since version
> 
> I forgot to mention that it looks like there might be some work to get avr 
> rtems target working with avr-libc. But that is unknown timing at this 
> point.

If --with-avrlibc is extended to work with RTEMS, the docs should reflect that,
of course.  But this is independent from the state of AVR-Libc.

> Ok to commit with the changes you made.

I used a different formulation because I found the "for non-RTEMS
configurations, which currently use newlib" confusing:

  "This option is only supported for the AVR target.  It is not supported
   for RTEMS configurations, which currently use newlib."

http://gcc.gnu.org/viewcvs?view=revision&revision=194978

Johann
Weddington, Eric - Jan. 7, 2013, 4:24 p.m.
> -----Original Message-----

> From: Georg-Johann Lay [mailto:avr@gjlay.de]

> Sent: Monday, January 07, 2013 9:17 AM

> To: Weddington, Eric

> Cc: gcc-patches@gcc.gnu.org; Denis Chertykov; Gerald Pfeifer

> Subject: Re: [patch,doc,avr] ad PR54461: Document --with-avrlibc

> 

> 

> I used a different formulation because I found the "for non-RTEMS

> configurations, which currently use newlib" confusing:

> 

>   "This option is only supported for the AVR target.  It is not

> supported

>    for RTEMS configurations, which currently use newlib."


Looks great! Thanks for understanding my intent. :-)

Eric

Patch

Index: doc/install.texi
===================================================================
--- doc/install.texi	(revision 194964)
+++ doc/install.texi	(working copy)
@@ -1813,6 +1813,16 @@  being used as the target C library.  Thi
 omitted from @file{libgcc.a} on the assumption that it will be provided by
 @samp{newlib}.
 
+@item --with-avrlibc
+Specifies that @samp{AVR-Libc} is
+being used as the target C library.  This causes float support
+functions like @code{__addsf3} to be omitted from @file{libgcc.a} on
+the assumption that it will be provided by @file{libm.a}.  For more
+technical details, cf. @uref{http://gcc.gnu.org/PR54461,,PR54461}.
+This option is only supported for the AVR target and only for
+non-RTEMS configurations.  The options is supported since version
+4.7.2 and is the default in 4.8.0 and newer.
+
 @item --with-build-time-tools=@var{dir}
 Specifies where to find the set of target tools (assembler, linker, etc.)
 that will be used while building GCC itself.  This option can be useful