Patchwork [U-Boot,2/2] video:cache:fix:trats: Enable dcache flush for TRATS board's LCD subsystem

login
register
mail settings
Submitter Łukasz Majewski
Date Jan. 7, 2013, 9:23 a.m.
Message ID <1357550590-4652-2-git-send-email-l.majewski@samsung.com>
Download mbox | patch
Permalink /patch/209885/
State Changes Requested
Delegated to: Anatolij Gustschin
Headers show

Comments

Łukasz Majewski - Jan. 7, 2013, 9:23 a.m.
lcd_set_flush_dcache(1) function is called from trats configuration file
to enable lcd_sync function.

Tested-at: TRATS (Exynos 4210)
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
 board/samsung/trats/trats.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Minkyu Kang - Jan. 8, 2013, 12:55 a.m.
On 07/01/13 18:23, Lukasz Majewski wrote:
> lcd_set_flush_dcache(1) function is called from trats configuration file
> to enable lcd_sync function.
> 
> Tested-at: TRATS (Exynos 4210)
> Tested-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/trats/trats.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 88d193d..5d0fdd0 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -789,5 +789,8 @@ void init_panel_info(vidinfo_t *vid)
>  	s6e8ax0_init();
>  	exynos_set_dsim_platform_data(&s6e8ax0_platform_data);
>  
> +	/* Enable flushing after LCD writes if requested */
> +	lcd_set_flush_dcache(1);
> +
>  	setenv("lcdinfo", "lcd=s6e8ax0");
>  }
> 

Acked-by: Minkyu Kang <mk7.kang@samsung.com>

---
Thanks,
Minkyu Kang.
Simon Glass - Jan. 8, 2013, 1:08 a.m.
On Mon, Jan 7, 2013 at 1:23 AM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> lcd_set_flush_dcache(1) function is called from trats configuration file
> to enable lcd_sync function.
>
> Tested-at: TRATS (Exynos 4210)
> Tested-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  board/samsung/trats/trats.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 88d193d..5d0fdd0 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -789,5 +789,8 @@ void init_panel_info(vidinfo_t *vid)
>         s6e8ax0_init();
>         exynos_set_dsim_platform_data(&s6e8ax0_platform_data);
>
> +       /* Enable flushing after LCD writes if requested */
> +       lcd_set_flush_dcache(1);
> +
>         setenv("lcdinfo", "lcd=s6e8ax0");
>  }
> --
> 1.7.2.3
>
Minkyu Kang - Jan. 8, 2013, 9:43 a.m.
Dear Lukasz,

On 07/01/13 18:23, Lukasz Majewski wrote:
> lcd_set_flush_dcache(1) function is called from trats configuration file
> to enable lcd_sync function.
> 
> Tested-at: TRATS (Exynos 4210)
> Tested-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
>  board/samsung/trats/trats.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 88d193d..5d0fdd0 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -789,5 +789,8 @@ void init_panel_info(vidinfo_t *vid)
>  	s6e8ax0_init();
>  	exynos_set_dsim_platform_data(&s6e8ax0_platform_data);
>  
> +	/* Enable flushing after LCD writes if requested */
> +	lcd_set_flush_dcache(1);

Please move it into exynos_fb.c (lcd_ctrl_init? or somewhere)

> +
>  	setenv("lcdinfo", "lcd=s6e8ax0");
>  }
> 

Thanks,
Minkyu Kang.

Patch

diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
index 88d193d..5d0fdd0 100644
--- a/board/samsung/trats/trats.c
+++ b/board/samsung/trats/trats.c
@@ -789,5 +789,8 @@  void init_panel_info(vidinfo_t *vid)
 	s6e8ax0_init();
 	exynos_set_dsim_platform_data(&s6e8ax0_platform_data);
 
+	/* Enable flushing after LCD writes if requested */
+	lcd_set_flush_dcache(1);
+
 	setenv("lcdinfo", "lcd=s6e8ax0");
 }