From patchwork Mon Jan 7 04:42:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: drivers/net/wireless/iwlegacy: use strlcpy instead of strncpy Date: Sun, 06 Jan 2013 18:42:46 -0000 From: Chen Gang X-Patchwork-Id: 209853 Message-Id: <50EA5246.8060206@asianux.com> To: sgruszka@redhat.com, linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, netdev The fields must be null-terminated, or simple_strtoul will cause issue. Signed-off-by: Chen Gang --- drivers/net/wireless/iwlegacy/3945-mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c index d604b40..3726cd6 100644 --- a/drivers/net/wireless/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/iwlegacy/3945-mac.c @@ -3273,7 +3273,7 @@ il3945_store_measurement(struct device *d, struct device_attribute *attr, if (count) { char *p = buffer; - strncpy(buffer, buf, min(sizeof(buffer), count)); + strlcpy(buffer, buf, sizeof(buffer)); channel = simple_strtoul(p, NULL, 0); if (channel) params.channel = channel;