Patchwork ARM: tegra30: make the wait time of CPU power up to proportional to HZ

login
register
mail settings
Submitter Joseph Lo
Date Jan. 7, 2013, 2:56 a.m.
Message ID <1357527374-31055-1-git-send-email-josephl@nvidia.com>
Download mbox | patch
Permalink /patch/209846/
State Accepted, archived
Headers show

Comments

Joseph Lo - Jan. 7, 2013, 2:56 a.m.
It would rather to use the API of time_to_jiffies than a constant number
of jiffies for the wait time of CPU power up.

Based on the work by:
Sang-Hun Lee <sanlee@nvidia.com>

Signed-off-by: Joseph Lo <josephl@nvidia.com>
---
 arch/arm/mach-tegra/platsmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Stephen Warren - Jan. 7, 2013, 5:41 p.m.
On 01/06/2013 07:56 PM, Joseph Lo wrote:
> It would rather to use the API of time_to_jiffies than a constant number
> of jiffies for the wait time of CPU power up.
> 
> Based on the work by:
> Sang-Hun Lee <sanlee@nvidia.com>

Applied to Tegra's for-3.9/soc branch.

> diff --git a/arch/arm/mach-tegra/platsmp.c b/arch/arm/mach-tegra/platsmp.c

> -		timeout = jiffies + 5*HZ;
> +		timeout = jiffies + msecs_to_jiffies(50);

I did just want to confirm though; I think that changes the timeout from
5 seconds to 50mS and similarly for the other change. I assume that was
intended? The code certainly seemed to work just fine with this change
when I tested it.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joseph Lo - Jan. 8, 2013, 1:24 a.m.
On Tue, 2013-01-08 at 01:41 +0800, Stephen Warren wrote:
> On 01/06/2013 07:56 PM, Joseph Lo wrote:
> > It would rather to use the API of time_to_jiffies than a constant number
> > of jiffies for the wait time of CPU power up.
> > 
> > Based on the work by:
> > Sang-Hun Lee <sanlee@nvidia.com>
> 
> Applied to Tegra's for-3.9/soc branch.
> 
> > diff --git a/arch/arm/mach-tegra/platsmp.c b/arch/arm/mach-tegra/platsmp.c
> 
> > -		timeout = jiffies + 5*HZ;
> > +		timeout = jiffies + msecs_to_jiffies(50);
> 
> I did just want to confirm though; I think that changes the timeout from
> 5 seconds to 50mS and similarly for the other change. I assume that was
> intended? The code certainly seemed to work just fine with this change
> when I tested it.

Yes, I also tested this patch with CPU hotplug stress test. The result
was good.

Thanks for confirming.

Joseph

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-tegra/platsmp.c b/arch/arm/mach-tegra/platsmp.c
index 60daf9f..6867030 100644
--- a/arch/arm/mach-tegra/platsmp.c
+++ b/arch/arm/mach-tegra/platsmp.c
@@ -90,7 +90,7 @@  static int tegra30_power_up_cpu(unsigned int cpu)
 	 * next time around.
 	 */
 	if (cpumask_test_cpu(cpu, &tegra_cpu_init_mask)) {
-		timeout = jiffies + 5*HZ;
+		timeout = jiffies + msecs_to_jiffies(50);
 		do {
 			if (!tegra_powergate_is_powered(pwrgateid))
 				goto remove_clamps;
@@ -110,7 +110,7 @@  static int tegra30_power_up_cpu(unsigned int cpu)
 			return ret;
 
 		/* Wait for the power to come up. */
-		timeout = jiffies + 10*HZ;
+		timeout = jiffies + msecs_to_jiffies(100);
 		while (tegra_powergate_is_powered(pwrgateid)) {
 			if (time_after(jiffies, timeout))
 				return -ETIMEDOUT;