Patchwork [07/28] xserver_xorg-server: add more explanations about the two variants

login
register
mail settings
Submitter Thomas Petazzoni
Date Jan. 6, 2013, 9:29 p.m.
Message ID <4383e0addeae7263c37e627d0df1e42ea73f13d1.1357507764.git.thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/209825/
State Accepted
Headers show

Comments

Thomas Petazzoni - Jan. 6, 2013, 9:29 p.m.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/x11r7/xserver_xorg-server/Config.in |   10 ++++++++++
 1 file changed, 10 insertions(+)
Arnout Vandecappelle - Jan. 8, 2013, 11:08 p.m.
On 01/06/13 22:29, Thomas Petazzoni wrote:
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
  (untested)

> ---
>   package/x11r7/xserver_xorg-server/Config.in |   10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
> index 2382786..6c70196 100644
> --- a/package/x11r7/xserver_xorg-server/Config.in
> +++ b/package/x11r7/xserver_xorg-server/Config.in
> @@ -68,12 +68,22 @@ choice
>   config BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
>   	bool "Modular X.org"
>   	depends on BR2_LARGEFILE&&  BR2_INSTALL_LIBSTDCPP
> +	help
> +	  This variant of the X.org server is the full-blown variant,
> +	  as used by desktop GNU/Linux distributions. The drivers (for
> +	  input and graphics) are built separately from the X.org
> +	  server (see the xdriver* packages).

  Come to think of it, it would be more logical to move these packages 
directly below the xorg-server config option.


>   comment "X.org requires largefile and C++ support"
              ^
              Modular X.org
  would also be an improvement.

>   	depends on !(BR2_LARGEFILE&&  BR2_INSTALL_LIBSTDCPP)
>
>   config BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
>   	bool "KDrive / TinyX"
> +	help
> +	  This variant of the X.org server is a lightweight version
> +	  intended for embedded systems. The drivers (for input and
> +	  graphics) are built into the server. It is generally used
> +	  directly on top of the Linux framebuffer.

  without DRM or video card specific drivers.

  Right?

  Regards,
  Arnout

>
>   endchoice
>
Peter Korsgaard - Jan. 12, 2013, 9:34 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed with a few changes to the help text as pointed out by Arnout,
thanks.

Patch

diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index 2382786..6c70196 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -68,12 +68,22 @@  choice
 config BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR
 	bool "Modular X.org"
 	depends on BR2_LARGEFILE && BR2_INSTALL_LIBSTDCPP
+	help
+	  This variant of the X.org server is the full-blown variant,
+	  as used by desktop GNU/Linux distributions. The drivers (for
+	  input and graphics) are built separately from the X.org
+	  server (see the xdriver* packages).
 
 comment "X.org requires largefile and C++ support"
 	depends on !(BR2_LARGEFILE && BR2_INSTALL_LIBSTDCPP)
 
 config BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE
 	bool "KDrive / TinyX"
+	help
+	  This variant of the X.org server is a lightweight version
+	  intended for embedded systems. The drivers (for input and
+	  graphics) are built into the server. It is generally used
+	  directly on top of the Linux framebuffer.
 
 endchoice