From patchwork Sun Jan 6 21:29:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 209824 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id D59B02C0085 for ; Mon, 7 Jan 2013 08:32:59 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9AF4630EB8; Sun, 6 Jan 2013 21:32:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eyYz8q5QUGoD; Sun, 6 Jan 2013 21:32:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 3452330F12; Sun, 6 Jan 2013 21:32:09 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 42F9E8F753 for ; Sun, 6 Jan 2013 21:30:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 06F888C25B for ; Sun, 6 Jan 2013 21:30:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QLDarhF3Dm0I for ; Sun, 6 Jan 2013 21:30:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [94.23.32.191]) by whitealder.osuosl.org (Postfix) with ESMTP id 0ABE28C1DD for ; Sun, 6 Jan 2013 21:30:05 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 861FB161; Sun, 6 Jan 2013 22:30:06 +0100 (CET) Received: from localhost (humanoidz.org [82.247.183.72]) by mail.free-electrons.com (Postfix) with ESMTPSA id B3538138 for ; Sun, 6 Jan 2013 22:30:05 +0100 (CET) From: Thomas Petazzoni To: buildroot@busybox.net Date: Sun, 6 Jan 2013 22:29:20 +0100 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Subject: [Buildroot] [PATCH 08/28] x11r7: do not globally select libraries X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net It doesn't make sense for BR2_PACKAGE_XORG7 to globally select libraries such as libpng, zlib, expat or fontconfig. For example, if you do a build with just xlib_libX11, then libpng gets built as the last package, without anybody actually depending on it, even if it was selected by BR2_PACKAGE_XORG7. The individual x11r7 packages should select the libraries they need, and add them in their DEPENDENCIES variable. Signed-off-by: Thomas Petazzoni --- package/x11r7/Config.in | 4 ---- 1 file changed, 4 deletions(-) diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in index 6940725..706574c 100644 --- a/package/x11r7/Config.in +++ b/package/x11r7/Config.in @@ -1,9 +1,5 @@ menuconfig BR2_PACKAGE_XORG7 bool "X.org X Window System" - select BR2_PACKAGE_ZLIB - select BR2_PACKAGE_LIBPNG - select BR2_PACKAGE_EXPAT - select BR2_PACKAGE_FONTCONFIG depends on BR2_USE_WCHAR help Support for X11R7 libraries, servers, drivers, and/or