Patchwork [08/28] x11r7: do not globally select libraries

login
register
mail settings
Submitter Thomas Petazzoni
Date Jan. 6, 2013, 9:29 p.m.
Message ID <d72dbd3289911f78a4e38a783cbddafd3cfd5fef.1357507764.git.thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/209824/
State Accepted
Commit 3679abe0a32e2559c81a9f47820c9af47ee1f84f
Headers show

Comments

Thomas Petazzoni - Jan. 6, 2013, 9:29 p.m.
It doesn't make sense for BR2_PACKAGE_XORG7 to globally select
libraries such as libpng, zlib, expat or fontconfig. For example, if
you do a build with just xlib_libX11, then libpng gets built as the
last package, without anybody actually depending on it, even if it was
selected by BR2_PACKAGE_XORG7.

The individual x11r7 packages should select the libraries they need,
and add them in their DEPENDENCIES variable.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/x11r7/Config.in |    4 ----
 1 file changed, 4 deletions(-)
Arnout Vandecappelle - Jan. 8, 2013, 11:21 p.m.
On 01/06/13 22:29, Thomas Petazzoni wrote:
> It doesn't make sense for BR2_PACKAGE_XORG7 to globally select
> libraries such as libpng, zlib, expat or fontconfig. For example, if
> you do a build with just xlib_libX11, then libpng gets built as the
> last package, without anybody actually depending on it, even if it was
> selected by BR2_PACKAGE_XORG7.
>
> The individual x11r7 packages should select the libraries they need,
> and add them in their DEPENDENCIES variable.
>
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>

  Although this is of course a very good idea, it's also risky. Possibly 
there are some X packages that rely on this implicit select. But I guess 
the autobuilders will expose those.


  Regards,
  Arnout

> ---
>   package/x11r7/Config.in |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in
> index 6940725..706574c 100644
> --- a/package/x11r7/Config.in
> +++ b/package/x11r7/Config.in
> @@ -1,9 +1,5 @@
>   menuconfig BR2_PACKAGE_XORG7
>   	bool "X.org X Window System"
> -	select BR2_PACKAGE_ZLIB
> -	select BR2_PACKAGE_LIBPNG
> -	select BR2_PACKAGE_EXPAT
> -	select BR2_PACKAGE_FONTCONFIG
>   	depends on BR2_USE_WCHAR
>   	help
>   	  Support for X11R7 libraries, servers, drivers, and/or
Thomas Petazzoni - Jan. 8, 2013, 11:29 p.m.
Dear Arnout Vandecappelle,

On Wed, 09 Jan 2013 00:21:17 +0100, Arnout Vandecappelle wrote:

>   Although this is of course a very good idea, it's also risky. Possibly 
> there are some X packages that rely on this implicit select. But I guess 
> the autobuilders will expose those.

Yes, it is risky, but it was clearly incorrect and needs to be fixed.
I've built a number of X.org libraries and applications to uncover
missing dependencies while doing the rest of the patch series, and it
went fine. We'll see what the autobuilders have to say, though :-)

Thomas
Peter Korsgaard - Jan. 12, 2013, 9:34 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> It doesn't make sense for BR2_PACKAGE_XORG7 to globally select
 Thomas> libraries such as libpng, zlib, expat or fontconfig. For example, if
 Thomas> you do a build with just xlib_libX11, then libpng gets built as the
 Thomas> last package, without anybody actually depending on it, even if it was
 Thomas> selected by BR2_PACKAGE_XORG7.

Committed, thanks.

Patch

diff --git a/package/x11r7/Config.in b/package/x11r7/Config.in
index 6940725..706574c 100644
--- a/package/x11r7/Config.in
+++ b/package/x11r7/Config.in
@@ -1,9 +1,5 @@ 
 menuconfig BR2_PACKAGE_XORG7
 	bool "X.org X Window System"
-	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_LIBPNG
-	select BR2_PACKAGE_EXPAT
-	select BR2_PACKAGE_FONTCONFIG
 	depends on BR2_USE_WCHAR
 	help
 	  Support for X11R7 libraries, servers, drivers, and/or