Patchwork [20/28] atk: remove unused host variant

login
register
mail settings
Submitter Thomas Petazzoni
Date Jan. 6, 2013, 9:29 p.m.
Message ID <fef01e5a74239111bcc590fa096f376fe51cc2ae.1357507764.git.thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/209823/
State Accepted
Commit b19ee5cbdf8978d593805483a92b4c9d00c0da76
Headers show

Comments

Thomas Petazzoni - Jan. 6, 2013, 9:29 p.m.
The atk package is used as a dependency in the libglade and libgtk2
packages.

The libglade package has no host variant, and does not depend on
host-atk.

The libgtk2 package depends on atk, and has a host variant, but the
host variant of libgtk2 overrides HOST_LIBGTK2_DEPENDENCIES to limit
the number of dependencies, and host-atk is not amongst those
dependencies.

Therefore, host-atk is useless and can be removed.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/atk/atk.mk |    4 ----
 1 file changed, 4 deletions(-)
Peter Korsgaard - Jan. 12, 2013, 9:48 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> The atk package is used as a dependency in the libglade and libgtk2
 Thomas> packages.

 Thomas> The libglade package has no host variant, and does not depend on
 Thomas> host-atk.

 Thomas> The libgtk2 package depends on atk, and has a host variant, but the
 Thomas> host variant of libgtk2 overrides HOST_LIBGTK2_DEPENDENCIES to limit
 Thomas> the number of dependencies, and host-atk is not amongst those
 Thomas> dependencies.

 Thomas> Therefore, host-atk is useless and can be removed.

Committed, thanks.

Patch

diff --git a/package/atk/atk.mk b/package/atk/atk.mk
index 0453acb..2a85edd 100644
--- a/package/atk/atk.mk
+++ b/package/atk/atk.mk
@@ -43,8 +43,4 @@  ATK_CONF_OPT =  --disable-glibtest --enable-explicit-deps=no \
 
 ATK_DEPENDENCIES = libglib2 host-pkgconf
 
-HOST_ATK_CONF_OPT = \
-		--disable-glibtest
-
 $(eval $(autotools-package))
-$(eval $(host-autotools-package))