Patchwork [1/3] libcofi: new package

login
register
mail settings
Submitter Maxime Hadjinlian
Date Jan. 6, 2013, 8:56 p.m.
Message ID <ca62bc23d6fea2e485408cce7bfdf1835a4bfb15.1357505417.git.maxime.hadjinlian@gmail.com>
Download mbox | patch
Permalink /patch/209802/
State Accepted
Headers show

Comments

Maxime Hadjinlian - Jan. 6, 2013, 8:56 p.m.
replacement for memcpy and memset functionality
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in          |    1 +
 package/libcofi/Config.in  |    8 ++++++++
 package/libcofi/libcofi.mk |   20 ++++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/libcofi/Config.in
 create mode 100644 package/libcofi/libcofi.mk
Peter Korsgaard - Jan. 6, 2013, 9:02 p.m.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 Maxime> replacement for memcpy and memset functionality

 Maxime> This package was originally found at :
 Maxime> https://github.com/huceke/buildroot-rbp By gimli
 Maxime> <ebsi4711@gmail.com>

The package looks ok from a quick look, but how is it supposed to be
used? I wouldn't like to see patches to a bunch of packages to link
against this.

It isn't really rpi specific either.
Maxime Hadjinlian - Jan. 6, 2013, 9:13 p.m.
On Sun, Jan 6, 2013 at 10:02 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
>  Maxime> replacement for memcpy and memset functionality
>
>  Maxime> This package was originally found at :
>  Maxime> https://github.com/huceke/buildroot-rbp By gimli
>  Maxime> <ebsi4711@gmail.com>
>
> The package looks ok from a quick look, but how is it supposed to be
> used? I wouldn't like to see patches to a bunch of packages to link
> against this.
As the author of the package says, the library is used using
LD_PRELOAD on the target.
So no patch should be needed for any packages.
>
> It isn't really rpi specific either.
I don't know about that, the author says it's rpi specific.
>
> --
> Bye, Peter Korsgaard
Peter Korsgaard - Jan. 6, 2013, 9:18 p.m.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

Hi,

 >> The package looks ok from a quick look, but how is it supposed to be
 >> used? I wouldn't like to see patches to a bunch of packages to link
 >> against this.
 Maxime> As the author of the package says, the library is used using
 Maxime> LD_PRELOAD on the target.
 Maxime> So no patch should be needed for any packages.

Ok, great.

 >> 
 >> It isn't really rpi specific either.
 Maxime> I don't know about that, the author says it's rpi specific.

The optimizations presumably also applies to other ARM11(76) processors
with similar memory speed.
Maxime Hadjinlian - Jan. 6, 2013, 9:21 p.m.
On Sun, Jan 6, 2013 at 10:18 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
> Hi,
>
>  >> The package looks ok from a quick look, but how is it supposed to be
>  >> used? I wouldn't like to see patches to a bunch of packages to link
>  >> against this.
>  Maxime> As the author of the package says, the library is used using
>  Maxime> LD_PRELOAD on the target.
>  Maxime> So no patch should be needed for any packages.
>
> Ok, great.
>
>  >>
>  >> It isn't really rpi specific either.
>  Maxime> I don't know about that, the author says it's rpi specific.
>
> The optimizations presumably also applies to other ARM11(76) processors
> with similar memory speed.
You're absolutely right, if someone as such a platform, it would be
great to know if it works or not !
>
> --
> Bye, Peter Korsgaard
Peter Korsgaard - Jan. 6, 2013, 10:02 p.m.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 Maxime> replacement for memcpy and memset functionality
 Maxime> This package was originally found at : https://github.com/huceke/buildroot-rbp
 Maxime> By gimli <ebsi4711@gmail.com>

 Maxime> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 Maxime> ---
 Maxime>  package/Config.in          |    1 +
 Maxime>  package/libcofi/Config.in  |    8 ++++++++
 Maxime>  package/libcofi/libcofi.mk |   20 ++++++++++++++++++++
 Maxime>  3 files changed, 29 insertions(+)
 Maxime>  create mode 100644 package/libcofi/Config.in
 Maxime>  create mode 100644 package/libcofi/libcofi.mk

 Maxime> diff --git a/package/Config.in b/package/Config.in
 Maxime> index 047af8d..9b50f4b 100644
 Maxime> --- a/package/Config.in
 Maxime> +++ b/package/Config.in
 Maxime> @@ -511,6 +511,7 @@ endmenu
 Maxime>  menu "Other"
 Maxime>  source "package/apr/Config.in"
 Maxime>  source "package/apr-util/Config.in"
 Maxime> +source "package/libcofi/Config.in"
 Maxime>  source "package/classpath/Config.in"
 Maxime>  source "package/fftw/Config.in"
 Maxime>  source "package/libargtable2/Config.in"
 Maxime> diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
 Maxime> new file mode 100644
 Maxime> index 0000000..b900b69
 Maxime> --- /dev/null
 Maxime> +++ b/package/libcofi/Config.in
 Maxime> @@ -0,0 +1,8 @@
 Maxime> +config BR2_PACKAGE_LIBCOFI
 Maxime> +	bool "libcofi"
 Maxime> +	depends on BR2_arm
 Maxime> +	help
 Maxime> +	  A replacement for memcpy and memset functionality for the Raspberry Pi

I've word wrapped this and committed, thanks.

Patch

diff --git a/package/Config.in b/package/Config.in
index 047af8d..9b50f4b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -511,6 +511,7 @@  endmenu
 menu "Other"
 source "package/apr/Config.in"
 source "package/apr-util/Config.in"
+source "package/libcofi/Config.in"
 source "package/classpath/Config.in"
 source "package/fftw/Config.in"
 source "package/libargtable2/Config.in"
diff --git a/package/libcofi/Config.in b/package/libcofi/Config.in
new file mode 100644
index 0000000..b900b69
--- /dev/null
+++ b/package/libcofi/Config.in
@@ -0,0 +1,8 @@ 
+config BR2_PACKAGE_LIBCOFI
+	bool "libcofi"
+	depends on BR2_arm
+	help
+	  A replacement for memcpy and memset functionality for the Raspberry Pi
+	  with the intention of gaining greater performance.
+
+	  https://github.com/simonjhall/copies-and-fills
diff --git a/package/libcofi/libcofi.mk b/package/libcofi/libcofi.mk
new file mode 100644
index 0000000..e2ce702
--- /dev/null
+++ b/package/libcofi/libcofi.mk
@@ -0,0 +1,20 @@ 
+#############################################################
+#
+# libcofi
+#
+#############################################################
+
+LIBCOFI_VERSION = 7313fbe12b0593034d0a1b606bf33c7cf4ababce
+LIBCOFI_SITE = http://github.com/simonjhall/copies-and-fills/tarball/master
+LIBCOFI_LICENSE = LGPLv2.1
+LIBCOFI_LICENSE_FILES = README.md
+
+define LIBCOFI_BUILD_CMDS
+    $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+endef
+
+define LIBCOFI_INSTALL_TARGET_CMDS
+    $(INSTALL) -D -m 0755 $(@D)/libcofi_rpi.so $(TARGET_DIR)/usr/lib/libcofi_rpi.so
+endef
+
+$(eval $(generic-package))