From patchwork Sun Jan 6 12:25:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: mke2fs: check extents feature when bigalloc feature is enabled Date: Sun, 06 Jan 2013 02:25:17 -0000 From: Zheng Liu X-Patchwork-Id: 209747 Message-Id: <1357475117-5095-1-git-send-email-wenqing.lz@taobao.com> To: linux-ext4@vger.kernel.org Cc: Zheng Liu From: Zheng Liu When bigalloc feature is enabled in mkfs, extents feature also needs to be enabled. But now when bigalloc feature is enabled without extents feature, users will not get any warning messages until they try to mount this file system. Signed-off-by: Zheng Liu --- misc/mke2fs.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/misc/mke2fs.c b/misc/mke2fs.c index a288147..713eb21 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -1988,6 +1988,15 @@ profile_error: fs_param.s_feature_ro_compat &= ~EXT4_FEATURE_RO_COMPAT_GDT_CSUM; + /* Can't support bigalloc feature without extents feature */ + if ((fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) && + !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) { + com_err(program_name, 0, + _("Can't support bigalloc feature without " + "extents feature")); + exit(1); + } + /* Since sparse_super is the default, we would only have a problem * here if it was explicitly disabled. */