Message ID | 1357475117-5095-1-git-send-email-wenqing.lz@taobao.com |
---|---|
State | Accepted, archived |
Headers | show |
On Sun, Jan 06, 2013 at 08:25:17PM +0800, Zheng Liu wrote: > From: Zheng Liu <wenqing.lz@taobao.com> > > When bigalloc feature is enabled in mkfs, extents feature also needs to be > enabled. But now when bigalloc feature is enabled without extents feature, > users will not get any warning messages until they try to mount this file > system. > > Signed-off-by: Zheng Liu <wenqing.lz@taobao.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/misc/mke2fs.c b/misc/mke2fs.c index a288147..713eb21 100644 --- a/misc/mke2fs.c +++ b/misc/mke2fs.c @@ -1988,6 +1988,15 @@ profile_error: fs_param.s_feature_ro_compat &= ~EXT4_FEATURE_RO_COMPAT_GDT_CSUM; + /* Can't support bigalloc feature without extents feature */ + if ((fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_BIGALLOC) && + !(fs_param.s_feature_incompat & EXT3_FEATURE_INCOMPAT_EXTENTS)) { + com_err(program_name, 0, + _("Can't support bigalloc feature without " + "extents feature")); + exit(1); + } + /* Since sparse_super is the default, we would only have a problem * here if it was explicitly disabled. */